feat: --asset-bundles forwards local-ab=true into the Explorer deep link - #1539
Merged
Conversation
The Desktop Explorer now owns asset-bundle conversion for local scene development (decentraland/unity-explorer#9704): with local-ab it spawns its own JIT converter against the preview's content server. sdk-commands therefore only needs to declare the flag and pass it through the deep link — no sidecar, no binary management, no extra endpoints. The flag name matches what the Creator Hub already spawns (decentraland/creator-hub#1396 feature-detects the quoted literal --asset-bundles in the installed sdk-commands and keys sidecar-aware behavior on local-ab being present in the captured deeplink), so this slots into the released Hub flow unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Deploying js-sdk-toolchain with
|
| Latest commit: |
4ef4ada
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46383e82.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://feat-local-ab-deeplink.js-sdk-toolchain.pages.dev |
Contributor
Test this pull request
|
pravusjif
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sdk-commands start --asset-bundlesnow just addslocal-ab=trueto the Desktop Explorer deep link. Nothing else: no sidecar process, no binary download, no proxy endpoints.Why
The Desktop Explorer now owns asset-bundle conversion for local scene development (decentraland/unity-explorer#9704): when it receives
local-ab, it spawns and supervises its own abgen JIT converter pointed at the preview's content server (which the realm already in the deep link carries). Conversion progress, caching, and failure reporting all live in the client's scene dev console.That makes the sdk-commands side of #1498 unnecessary — this PR is the minimal replacement: declare the flag, forward it.
Creator Hub compatibility (no Hub changes needed)
The merged decentraland/creator-hub#1396 flow works unchanged against this:
dist/commands/start/index.jsfor the quoted literal--asset-bundles— declaring the flag inargssatisfies that.sdk-commands start --explorer-alpha --hub --asset-bundles ...— accepted here.local-abwhen the toggle goes off) onlocal-abbeing present in the captured deep link — emitted here.Test plan
explorer-alpha.spec.ts:--asset-bundles→ deep link containslocal-ab=true; flag absent → nolocal-abparam.local-ab=truein the deep link and the Explorer's AB console shows the conversion; unchecked launches carry nolocal-ab.🤖 Generated with Claude Code