(protocol squad) main branch pr - #793
Open
leanmendoza wants to merge 113 commits into
Open
Conversation
Deploying js-sdk-toolchain with
|
| Latest commit: |
0c215c3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3fe37d48.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://protocol-squad.js-sdk-toolchain.pages.dev |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
- Coverage 62.33% 62.06% -0.28%
==========================================
Files 618 622 +4
Lines 20645 20876 +231
Branches 2518 2593 +75
==========================================
+ Hits 12870 12956 +86
- Misses 7338 7469 +131
- Partials 437 451 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leanmendoza
force-pushed
the
protocol-squad
branch
from
October 17, 2023 18:21
f9d4c2a to
6a20452
Compare
leanmendoza
changed the title
leanmendoza
changed the title
* feat: add bevy in start command * add locaiton * only pass base url * bevy versioning * fix urls and rmdir * do not open browser when dao-explorer is specified
* experimental cinematic camera * skip test * fix typo * wip * update protocol * update bevy release * update protocol
* bump protocol, update after build and add to react * add customEntryPoint to sdk-commands start * add wrap * add to react * update build * update @dcl/protocol
This reverts commit 9fa5dc0.
kuruk-mm
marked this pull request as ready for review
June 19, 2025 18:04
* multi-button ui * fix callback type * partial * lint * leave public Callback type unchanged, make new MultiCallback type * lint + doc * add event arg to single callback * onInputXXX * forgot about iaAny * fix ternary precedence * fix comparison * use correct event ordering for getInputCommands() * fix button cast * fix doc comments * lints * build... * rest of the lints * fix tests * fix lint * fix initial empty pointerEvents * update snapshot --------- Co-authored-by: Lean Mendoza <8042536+leanmendoza@users.noreply.github.com>
* feat: dynamic lights (#1186) * updated proto package and added tests for light source * updated proto package * 'make build' + 'make update-snapshots' * corrected LightSource test based on Material tests * removed test code * final version of LightSource serialization test * ran 'make lint-fix' * added light source helper * updated protocol package * added missing helper tests for LightSource * ran 'make lint-fix' --------- Co-authored-by: Pravus <pravusjif@gmail.com> * build with latest psquad package * update snapshots --------- Co-authored-by: daniele-dcl <daniele.marotta@decentraland.org> Co-authored-by: Pravus <pravusjif@gmail.com>
* clear/get focus * use @dcl/protocol with main branch updates * fix * fixes * lint --------- Co-authored-by: Mateo "Kuruk" Miccino <mateomiccino@gmail.com>
* fix textureRenderer wrong parameter must be the function component instead of the result object of it * update snapshots * remove test-inspector --------- Co-authored-by: pabloes <estornut@gmail.com>
# Conflicts: # package-lock.json # package.json # packages/@dcl/ecs/src/components/types.ts # packages/@dcl/playground-assets/etc/playground-assets.api.md # packages/@dcl/react-ecs/src/system.ts # packages/@dcl/sdk-commands/package-lock.json # packages/@dcl/sdk-commands/package.json # packages/@dcl/sdk-commands/src/commands/start/index.ts # test/snapshots/development-bundles/static-scene.test.ts.crdt # test/snapshots/development-bundles/testing-fw.test.ts.crdt # test/snapshots/development-bundles/two-way-crdt.test.ts.crdt # test/snapshots/package-lock.json # test/snapshots/production-bundles/append-value-crdt.ts.crdt # test/snapshots/production-bundles/billboard.ts.crdt # test/snapshots/production-bundles/cube-deleted.ts.crdt # test/snapshots/production-bundles/cube.ts.crdt # test/snapshots/production-bundles/cubes.ts.crdt # test/snapshots/production-bundles/pointer-events.ts.crdt # test/snapshots/production-bundles/schema-components.ts.crdt # test/snapshots/production-bundles/ui.ts.crdt # test/snapshots/production-bundles/with-main-function.ts.crdt
robtfm
force-pushed
the
protocol-squad
branch
from
February 11, 2026 17:12
d77a14f to
e132905
Compare
* update protocol * add ci on pr * update raycast spec * update ids * update snapshots * skip playground * add raycast params to helpers * add IA_MODIFIER
- Update @dcl/protocol to local build with WalkPlayerTo RPC and new walk fields - Add walkPlayerTo mock to scene-executor RestrictedActions - Regenerate snapshots for memory usage change from new types
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…1421) propsChanged diffed only the keys present in prevProps, so an optional prop that appears for the first time (absent from prevProps, present in nextProps) was silently dropped on its first change. scrollPosition is the canonical case: while undefined it is omitted from the parsed UiTransform, so the first `undefined -> reference` change produced no CRDT update at all. This is why the first scroll-to-target on a scrollable was lost while every subsequent change worked, and why a non-null initial scrollPosition avoided it. Add a second loop over nextProps for keys not in prevProps. This is allocation-free (no Object.keys/Set) to keep this per-frame hot path cheap.
npm publishing for the @dcl packages moved to trusted publishing (OIDC), which needs npm >= 11.5.1. Node 20's npm 10 falls back to the revoked NPM_TOKEN and every publish since May has failed with E404, so the protocol-squad npm tag is stuck at commit 83012ab (2026-04-27). Matches the Node pin main took in #1409/#1425.
* fix protocol-squad branch tests * fix(tests): pin typescript in dcl-test-lib-integration fixture `typescript: "*"` now resolves to TypeScript 6.0, which turns deprecated compiler options (downlevelIteration, moduleResolution=node10) into hard errors and also flags the missing rootDir (TS5101/TS5107/TS5011). That broke `tsc` for the lib fixture, so its bin/ was never produced and the dependent scene builds failed to resolve `dcl-test-lib-integration`, failing compile-lib-and-scene.spec.ts in CI. Mirror the fix already on `main`: pin typescript to ^5.0.2 and set rootDir.
protocol-squad had drifted 65 commits behind main, missing correctness fixes (entity-id collision #1332, CRDT suppression #1359, UiInput echo #1331) and features (ParticleSystem, physics forces, --no-client). Conflict resolutions, by intent: - @dcl/protocol stays THIS branch's tarball pin (root + sdk-commands) - start/index.ts takes main's launch machinery (--no-client, --mcp, forwarded params, mobile QR back to opt-in) but keeps bevy-web preview as this branch's default; main's sortedURLs[0] adapted to the object shape this file uses - events.ts is a semantic port, not a splice: main's proximity events (InteractionType threading, PET_PROXIMITY_* mappings, setters) re-implemented in this branch's per-button multi-callback idiom - AudioAnalysis is EXCLUDED: it needs audio_analysis.proto, which this branch's protocol does not carry yet; re-add when the proto lands - Component specs that main wrote against its newer protocol revert to this branch's versions (VirtualCamera fov etc.); ParticleSystem.spec adapted to this protocol's unwrapped repeated bursts - CLAUDE.md -> @AGENTS.md pointer (main's convention); the Unity renderer workflow stays deleted on this branch - Locks, playground api.md and .crdt snapshots regenerated, not merged make build && make test: 153 suites, 1144 tests green.
…quad Merge main into protocol-squad (keeping this branch's protocol)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm i @dcl/sdk@protocol-squadin your scene root folder.npm startto run Preview in Bevy