Merge branch 'chore/visual-test-app-args' of github.com:decentraland/unity-explorer into test/visual-tests

Author: pravusjif

Explorer/Assets/DCL/PluginSystem/Global/SkyboxPlugin.cs

@@ -67,7 +67,7 @@ public async UniTask InitializeAsync(SkyboxTimeSettings pluginSettings, Cancella
                     if (settingsJson.DayCycleDurationInSeconds != null)
                         skyboxSettings.FullDayCycleInSeconds =  settingsJson.DayCycleDurationInSeconds.Value;
 
-                SetInitialTime(settingsJson, skyboxSettings);
+                SetInitialTime(settingsJson, skyboxSettings, skyboxTimeEnabled);
 
                 skyboxRenderController = Object.Instantiate((await assetsProvisioner.ProvideMainAssetAsync(skyboxSettings.SkyboxRenderControllerPrefab, ct: ct)).Value);
 
@@ -83,7 +83,8 @@ public async UniTask InitializeAsync(SkyboxTimeSettings pluginSettings, Cancella
                     directionalLight,
                     skyboxAnimation,
                     skyboxSettings.TimeOfDayNormalized,
-                    lensFlareEnabled
+                    lensFlareEnabled,
+                    freezeTime: !skyboxTimeEnabled
                 );
 
                 if (!skyboxTimeEnabled)
@@ -101,8 +102,21 @@ public async UniTask InitializeAsync(SkyboxTimeSettings pluginSettings, Cancella
 
             return;
 
-            void SetInitialTime(SkyboxSettings jsonConfig, SkyboxSettingsAsset skyboxSettings)
+            void SetInitialTime(SkyboxSettings jsonConfig, SkyboxSettingsAsset skyboxSettings, bool timeEnabled)
             {
+                // When skybox time is disabled, pin the initial time to noon so it's independent of host
+                // clock / PlayerPrefs / FF — the update system that would honor those isn't injected here.
+                if (!timeEnabled)
+                {
+                    const float NOON = 0.5f;
+                    skyboxSettings.TimeOfDayNormalized = NOON;
+                    skyboxSettings.TargetTimeOfDayNormalized = NOON;
+                    skyboxSettings.UIOverrideTimeOfDayNormalized = NOON;
+                    skyboxSettings.IsUIControlled = true;
+                    skyboxSettings.IsDayCycleEnabled = false;
+                    return;
+                }
+
                 if (DCLPlayerPrefs.HasKey(DCLPrefKeys.SKYBOX_FIXED_TIME))
                 {
                     float fixedTime = DCLPlayerPrefs.GetFloat(DCLPrefKeys.SKYBOX_FIXED_TIME);

Explorer/Assets/DCL/SkyBox/SkyboxRenderController.cs

@@ -85,8 +85,16 @@ public class LensFlareTimeEntry
     [Header("Transition Settings")]
     [SerializeField] private float transitionDuration;
 
-    public void Initialize(Material skyboxMat, Light dirLight, AnimationClip skyboxAnimationClip, float initialTimeOfDay, bool lensFlareEnabled = true)
+    public void Initialize(Material skyboxMat, Light dirLight, AnimationClip skyboxAnimationClip, float initialTimeOfDay, bool lensFlareEnabled = true, bool freezeTime = false)
     {
+        // Pre-seed transition target so UpdateSkybox below short-circuits and skips the directional-light
+        // coroutine, whose first sync tick would Lerp from float.MinValue and clamp the gradient samplers.
+        if (freezeTime)
+        {
+            directionalLightTimeOfDay = initialTimeOfDay;
+            targetTimeOfDay = initialTimeOfDay;
+        }
+
         if (skyboxMat)
         {
 #if UNITY_EDITOR