-
Notifications
You must be signed in to change notification settings - Fork 17
chore: enable Alttester visual tests #8628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 32 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
dc4bad0
minimum implementation for '--disable-hud' app arg flag needed for vi…
pravusjif 23c32ea
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 8481dce
Merge branch 'dev' into chore/visual-test-app-args
pravusjif d9c29e7
Merge branch 'dev' into chore/visual-test-app-args
pravusjif bfd8373
refactored --disable-hud to avoid SDK UI
pravusjif 9821bee
Merge branch 'chore/visual-test-app-args' of github.com:decentraland/…
pravusjif 48f701c
implemented --graphics
pravusjif 3b47ddb
added visual tests determinism section in docs
pravusjif 9121464
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 5f57c3c
fixed skybox time values not bound to --skybox-time-enabled flag
pravusjif 62c066f
added --skip-minimum-specs-screen
pravusjif 1d0a9d9
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 60a7bd4
updated docs
pravusjif 1f59799
Merge branch 'dev' into chore/visual-test-app-args
pravusjif fe26266
added scene readiness probe for visual tests dynamic check
pravusjif cae4c98
Merge branch 'dev' into chore/visual-test-app-args
pravusjif e63a757
added github workflow for triggering Alttester Visual Tests with a Gi…
pravusjif 0bb373d
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 7ee1d3d
Merge branch 'dev' of github.com:decentraland/unity-explorer into cho…
pravusjif 65eb643
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 882f0d1
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 3a55381
Merge branch 'dev' of github.com:decentraland/unity-explorer into cho…
pravusjif 31c4136
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 6fe73ac
failing async tests refactor
pravusjif 84cd99c
async tests refactor again
pravusjif 2000a40
final tests correction
pravusjif 8c407e8
fix(native-window): use ExclusiveFullScreen when --resolution is pro…
popuz 4490a2a
Merge remote-tracking branch 'origin/chore/visual-test-app-args' into…
popuz 097f875
updated docs with alttester visual tests triggering info
pravusjif 7a2cde8
updated app arguments doc
pravusjif f4b7deb
Merge branch 'dev' into chore/visual-test-app-args
pravusjif 632242d
mini refactor of Fullscreen and Resolution override logic
pravusjif 38c7590
inherit fullscreen setting if no paramter or playerpref value is exis…
pravusjif 2d2d841
claude review feedback
pravusjif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,170 @@ | ||
| name: Visual Regression | ||
|
|
||
| # Slash-command-driven visual regression runner. The actual mechanics live in | ||
| # decentraland/explorer-automation's `run-visual-suite.yml` reusable workflow; | ||
| # this file only handles trigger validation, branch matching, and dispatching | ||
| # to that workflow. | ||
| # | ||
| # Trigger: | ||
| # Comment "/visual-tests" on a PR. Restricted to OWNER / MEMBER / | ||
| # COLLABORATOR author associations — anyone else's comment is silently | ||
| # ignored to keep this from becoming a free-CPU buffet for drive-by PRs. | ||
| # | ||
| # Branch matching: | ||
| # We look up the PR's head branch in explorer-automation. If that branch | ||
| # exists, we pass it as `tests_ref` so visual baselines and test fixtures | ||
| # from the matching feature branch are used. Otherwise we fall back to | ||
| # explorer-automation's default branch (metaforge handles the empty case | ||
| # internally). | ||
| # | ||
| # Required secrets / vars (configure once on the repo): | ||
| # | ||
| # Used directly by this dispatcher: | ||
| # - vars.DEV_EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL Constructs the Explorer build download URL | ||
| # | ||
| # Inherited by the reusable workflow via `secrets: inherit` — must exist | ||
| # on this repo even though the dispatcher itself doesn't reference them: | ||
| # - secrets.ALTTESTER_LICENSE | ||
| # - secrets.REPOS_READ_ONLY_TOKEN | ||
| # - secrets.DEV_EXPLORER_TEAM_S3_BUCKET | ||
| # - secrets.DEV_EXPLORER_TEAM_AWS_DEFAULT_REGION | ||
| # - secrets.DEV_EXPLORER_TEAM_AWS_ACCESS_KEY_ID | ||
| # - secrets.DEV_EXPLORER_TEAM_AWS_SECRET_ACCESS_KEY | ||
|
|
||
| on: | ||
| issue_comment: | ||
| types: [created] | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| concurrency: | ||
| group: visual-regression-${{ github.event.issue.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| resolve: | ||
| name: Resolve trigger | ||
| if: | | ||
| github.event.issue.pull_request && | ||
| startsWith(github.event.comment.body, '/visual-tests') | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| authorized: ${{ steps.gate.outputs.authorized }} | ||
| pr_number: ${{ steps.pr.outputs.number }} | ||
| build_url: ${{ steps.pr.outputs.build_url }} | ||
| tests_ref: ${{ steps.match.outputs.tests_ref }} | ||
| head_sha: ${{ steps.pr.outputs.head_sha }} | ||
| head_short_sha: ${{ steps.pr.outputs.head_short_sha }} | ||
| head_ref: ${{ steps.pr.outputs.head_ref }} | ||
|
|
||
| steps: | ||
| - name: Gate by author association | ||
| id: gate | ||
| env: | ||
| ASSOC: ${{ github.event.comment.author_association }} | ||
| run: | | ||
| set -euo pipefail | ||
| case "$ASSOC" in | ||
| OWNER|MEMBER|COLLABORATOR) | ||
| echo "authorized=true" >> "$GITHUB_OUTPUT" | ||
| ;; | ||
| *) | ||
| echo "::notice::Ignoring /visual-tests from $ASSOC ${{ github.event.comment.user.login }} — write access required." | ||
| echo "authorized=false" >> "$GITHUB_OUTPUT" | ||
| ;; | ||
| esac | ||
|
|
||
| - name: React to the trigger comment | ||
| if: steps.gate.outputs.authorized == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| gh api -X POST \ | ||
| "repos/${{ github.repository }}/issues/comments/${{ github.event.comment.id }}/reactions" \ | ||
| -f content=eyes >/dev/null | ||
|
|
||
| - name: Resolve PR head + build URL | ||
| id: pr | ||
| if: steps.gate.outputs.authorized == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PR_NUMBER: ${{ github.event.issue.number }} | ||
| PUBLIC_URL_PREFIX: ${{ vars.DEV_EXPLORER_TEAM_S3_BUCKET_PUBLIC_URL }} | ||
| run: | | ||
| set -euo pipefail | ||
|
|
||
| # 1. Fetch PR head — issue_comment events don't carry it in the payload. | ||
| PR_JSON=$(gh api "repos/${{ github.repository }}/pulls/${PR_NUMBER}") | ||
| HEAD_SHA=$(echo "$PR_JSON" | jq -r '.head.sha') | ||
| HEAD_REF=$(echo "$PR_JSON" | jq -r '.head.ref') | ||
| SHORT_SHA="${HEAD_SHA:0:7}" | ||
|
|
||
| # 2. Find the most recent successful Unity Cloud Build run for this SHA. | ||
| RUN_JSON=$(gh api "repos/${{ github.repository }}/actions/runs?head_sha=${HEAD_SHA}&status=success&per_page=20" \ | ||
| --jq '[.workflow_runs[] | select(.name == "Unity Cloud Build")] | .[0]') | ||
| if [ -z "$RUN_JSON" ] || [ "$RUN_JSON" = "null" ]; then | ||
| echo "::error::No successful Unity Cloud Build run found for SHA ${SHORT_SHA}. Is the build still in progress, or did it fail?" | ||
| exit 1 | ||
| fi | ||
| RUN_NUMBER=$(echo "$RUN_JSON" | jq -r '.run_number') | ||
| ORIGINAL_EVENT=$(echo "$RUN_JSON" | jq -r '.event') | ||
|
|
||
| # /visual-tests is only meaningful against a PR build. If the | ||
| # latest successful Unity Cloud Build for this SHA was triggered | ||
| # by something else (push to dev, scheduled run, manual dispatch), | ||
| # the artifact path uses a different prefix and our URL would | ||
| # 404. Fail loudly so the user knows to wait for a PR build | ||
| # rather than chasing a phantom 404 inside metaforge. | ||
| if [ "$ORIGINAL_EVENT" != "pull_request" ]; then | ||
| echo "::error::Latest successful Unity Cloud Build for ${SHORT_SHA} was triggered by '${ORIGINAL_EVENT}', not 'pull_request'. Visual tests can only run against PR builds." | ||
| exit 1 | ||
| fi | ||
|
|
||
| ARTIFACT_PATH="@dcl/${{ github.event.repository.name }}/branch/${HEAD_REF}/pr-${RUN_NUMBER}-${SHORT_SHA}" | ||
| BUILD_URL="${PUBLIC_URL_PREFIX}/${ARTIFACT_PATH}/Decentraland_macos.zip" | ||
|
|
||
| { | ||
| echo "number=${PR_NUMBER}" | ||
| echo "head_sha=${HEAD_SHA}" | ||
| echo "head_short_sha=${SHORT_SHA}" | ||
| echo "head_ref=${HEAD_REF}" | ||
| echo "build_url=${BUILD_URL}" | ||
| } >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Look up matching explorer-automation branch | ||
| id: match | ||
| if: steps.gate.outputs.authorized == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.REPOS_READ_ONLY_TOKEN }} | ||
| HEAD_REF: ${{ steps.pr.outputs.head_ref }} | ||
| run: | | ||
| set -euo pipefail | ||
| # 200 = branch exists on explorer-automation, use it as tests_ref. | ||
| # 404 = no matching branch, fall back to default (empty string => | ||
| # metaforge resolves to main). | ||
| if gh api "repos/decentraland/explorer-automation/branches/${HEAD_REF}" --silent >/dev/null 2>&1; then | ||
| echo "tests_ref=${HEAD_REF}" >> "$GITHUB_OUTPUT" | ||
| echo "::notice::Using matching explorer-automation branch '${HEAD_REF}'." | ||
| else | ||
| echo "tests_ref=" >> "$GITHUB_OUTPUT" | ||
| echo "::notice::No matching explorer-automation branch '${HEAD_REF}' — using default." | ||
| fi | ||
|
|
||
| run-suite: | ||
| name: Run visual suite | ||
| needs: resolve | ||
| if: needs.resolve.outputs.authorized == 'true' | ||
| # @main pins us to the merged version of the reusable workflow so PRs to | ||
| # explorer-automation that touch run-visual-suite.yml don't accidentally | ||
| # affect every unity-explorer PR's visual run. | ||
| uses: decentraland/explorer-automation/.github/workflows/run-visual-suite.yml@main | ||
| with: | ||
| mode: test | ||
| pr_number: ${{ needs.resolve.outputs.pr_number }} | ||
| build_url: ${{ needs.resolve.outputs.build_url }} | ||
| tests_ref: ${{ needs.resolve.outputs.tests_ref }} | ||
| commit_sha: ${{ needs.resolve.outputs.head_short_sha }} | ||
| branch_label: ${{ needs.resolve.outputs.head_ref }} | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
Explorer/Assets/DCL/Infrastructure/Global/Tests/PlayMode/BootstraperShould.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| using Cysharp.Threading.Tasks; | ||
| using Global.Dynamic; | ||
| using MVC; | ||
| using NSubstitute; | ||
| using NUnit.Framework; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Global.Tests.PlayMode | ||
| { | ||
| public class BootstraperShould | ||
| { | ||
| private IMVCManager mvcManager; | ||
|
|
||
| [SetUp] | ||
| public async void Setup() | ||
| { | ||
| mvcManager = Substitute.For<IMVCManager>(); | ||
| await UniTask.Yield(); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task DisableHudOnStartup_OnlyTouchesMVCCanvases_NotSceneUIDocuments() | ||
| { | ||
| // Workaround for Unity bug not awaiting async Setup correctly | ||
| await UniTask.WaitUntil(() => mvcManager != null); | ||
|
|
||
| await Bootstrap.DisableHudOnStartupAsync(mvcManager, CancellationToken.None); | ||
|
|
||
| mvcManager.Received(1).SetAllViewsCanvasActive(false); | ||
| mvcManager.DidNotReceiveWithAnyArgs().SetAllViewsCanvasActive(default(IController), default); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task DisableHudOnStartup_DoesNothing_WhenCancelledBeforeFrameAdvances() | ||
| { | ||
| // Workaround for Unity bug not awaiting async Setup correctly | ||
| await UniTask.WaitUntil(() => mvcManager != null); | ||
|
|
||
| var cts = new CancellationTokenSource(); | ||
| cts.Cancel(); | ||
|
|
||
| await Bootstrap.DisableHudOnStartupAsync(mvcManager, cts.Token); | ||
|
|
||
| mvcManager.DidNotReceiveWithAnyArgs().SetAllViewsCanvasActive(default); | ||
| } | ||
| } | ||
| } | ||
11 changes: 11 additions & 0 deletions
11
Explorer/Assets/DCL/Infrastructure/Global/Tests/PlayMode/BootstraperShould.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.