Skip to content

fix: proper cleanup of outfit state on panel close - #8832

Merged
davidejensen merged 1 commit into
devfrom
fix/outfits-button-state-reset
May 21, 2026
Merged

fix: proper cleanup of outfit state on panel close#8832
davidejensen merged 1 commit into
devfrom
fix/outfits-button-state-reset

Conversation

@davidejensen

Copy link
Copy Markdown
Member

Pull Request Description

What does this PR change?

Fix #8611
Resets outfit slot hover state when closing the backpack

Test Instructions

Test Steps

  1. Go to the outfits section.
  2. Hover any card and close the menu pressing [Esc] (or any of the other keys mentioned above) while still hovering the card.
  3. Reopen the outfits menu.
  4. Note that the outfits slots appear as they did the first time and no slot is in hover state unless actually hovered with the cursor

Additional Testing Notes

  • Note any edge cases to verify
  • Mention specific areas that need careful testing
  • List known limitations or potential issues

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.

@davidejensen davidejensen self-assigned this May 20, 2026
@davidejensen
davidejensen requested review from a team as code owners May 20, 2026 13:09
@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

@claude

claude Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

PR Review in Progress

  • Gather context and read PR diff
  • Read changed files
  • Analyze code quality against CLAUDE.md standards
  • Post review findings

View job run

@m3taphysics

Copy link
Copy Markdown
Contributor

PR #8832, run #26170140727

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric Change Baseline Delta Improvement
Samples 2700 2700
CPU average 33.3 ms 33.3 ms -0.0 ms 0.0%
CPU 1% worst 33.6 ms 33.6 ms -0.0 ms 0.0%
CPU 0.1% worst 34.8 ms 34.7 ms 0.1 ms -0.2%
GPU average 7.6 ms 7.6 ms -0.0 ms 0.5%
GPU 1% worst 22.3 ms 20.0 ms 2.3 ms -11.7% 🔴
GPU 0.1% worst 26.4 ms 26.2 ms 0.1 ms -0.4%

@DafGreco DafGreco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Log In/Log Out
  • [✔️ ] Backpack and wearables in world
  • [ ✔️] Emotes in world and in backpack
  • [ ✔️] Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer
  • [✔️ ] Profile card
  • [ ✔️] Skybox
  • [✔️ ] Settings

Evidence

20260520-1503-21.0593377.mp4

@davidejensen
davidejensen merged commit a0e665a into dev May 21, 2026
20 of 27 checks passed
@davidejensen
davidejensen deleted the fix/outfits-button-state-reset branch May 21, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QA] Outfits | Outfit card hover state not reset after closing the menu

4 participants