fix: maintain LocalPlayer-related data on all scenes

[mikhail-dcl]

Fixes decentraland/creator-hub#264

Problem

SDKProfile is propagated to the scene with 1 frame delay, making the following code fail onStart:

      const playerData = PlayerIdentityData.getOrNull(userEntity)
      const avatarData = AvatarBase.getOrNull(userEntity)
      const wearablesData = AvatarEquippedData.getOrNull(userEntity)

Solution

Make the whole set of Avatar-related components available on the systems' Initialize which is called before the scen starts. It's right the same flow seen in WriteMainPlayerTransformSystem

Sensitive changes

• User-related data now will be available for the scene even if it's not current
• To make it symmetric if the user profile is updated the corresponding data will be pushed to the scene as well (even if it's not current)
• The grey zone existed before: TransformComponent was available for the player entity right away whereas PlayerIdentityData, AvatarBase and AvatarEquippedData were not available until the player steps on the current scene

P.S. Behavior for remote peers has not changed.

How to QA

import { getPlayer } from '@dcl/sdk/src/players'

export function main() {

	let myPlayer = getPlayer()

	if (myPlayer) {
		console.log('Name : ', myPlayer.name)
		console.log('UserId : ', myPlayer.userId)
	}
}

• Execute the scene with the given script, you should see data properly logged.
• Perform regression on the scenes which are relying on the players' data

[github-actions]

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name	Link
Commit	e8dd6f9
Logs	https://github.com/decentraland/unity-explorer/actions/runs/27265756126
Download Windows	https://github.com/decentraland/unity-explorer/suites/73280548814/artifacts/7532427076
Download Windows S3	https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/seed-local-player-crdt-on-scene-init/pr-22865-e8dd6f9/Decentraland_windows64.zip
Download Mac	https://github.com/decentraland/unity-explorer/suites/73280548814/artifacts/7532035145
Download Mac S3	https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/feat/seed-local-player-crdt-on-scene-init/pr-22865-e8dd6f9/Decentraland_macos.zip
Built on	2026-06-10T09:59:22Z

[m3taphysics]

PR #8837, run #26182654059

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric	Change	Baseline	Delta	Improvement
Samples	2700	2700
CPU average	33.3 ms	33.3 ms	-0.0 ms	0.0%	⚪
CPU 1% worst	33.9 ms	34.0 ms	-0.1 ms	0.2%	⚪
CPU 0.1% worst	38.2 ms	37.2 ms	1.0 ms	-2.6%	⚪
GPU average	7.8 ms	7.9 ms	-0.1 ms	1.4%	⚪
GPU 1% worst	19.2 ms	18.6 ms	0.6 ms	-3.4%	🔴
GPU 0.1% worst	25.4 ms	23.5 ms	1.9 ms	-8.1%	🔴

[github-actions]

🔍 Claude reviewed this PR and found no blocking issues, but assessed it as complex — human DEV review is still required before merging.

[m3taphysics]

PR #8837, run #26220267637

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric	Change	Baseline	Delta	Improvement
Samples	2699	2700
CPU average	33.3 ms	33.3 ms	0.0 ms	-0.0%	⚪
CPU 1% worst	34.0 ms	33.7 ms	0.3 ms	-0.8%	⚪
CPU 0.1% worst	36.9 ms	36.0 ms	0.9 ms	-2.6%	⚪
GPU average	7.9 ms	7.7 ms	0.1 ms	-1.8%	⚪
GPU 1% worst	19.2 ms	20.3 ms	-1.2 ms	5.8%	🟢
GPU 0.1% worst	25.2 ms	24.5 ms	0.7 ms	-3.0%	🔴

[m3taphysics]

PR #8837, run #26226730238

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric	Change	Baseline	Delta	Improvement
Samples	2700	2699
CPU average	33.3 ms	33.3 ms	-0.0 ms	0.0%	⚪
CPU 1% worst	33.5 ms	33.9 ms	-0.4 ms	1.3%	⚪
CPU 0.1% worst	33.8 ms	37.6 ms	-3.8 ms	10.2%	🟢
GPU average	7.6 ms	7.9 ms	-0.3 ms	3.8%	🟢
GPU 1% worst	19.2 ms	19.6 ms	-0.4 ms	1.9%	⚪
GPU 0.1% worst	25.3 ms	25.1 ms	0.2 ms	-0.9%	⚪

[DafGreco]

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

• [✔️ ] Backpack and wearables in world
• [✔️ ] Emotes in world and in backpack
• [ ✔️] Teleport with map/coordinates/Jump In
• [✔️ ] Chat and multiplayer
• [ ✔️] Profile card
• [ ✔️] Skybox
• [ ✔️] Settings

In order to re-create this one :

1. Open the index of a scene folder
2. Copy the text and erase the other one inside index
3. Save the new text
4. npm i on the src code
5. npm run start
6. check that when enteering to the scene the console mentions the name and wallet of the user

Evidence:

20260522-0824-01.1221605.mp4

[m3taphysics]

PR #8837, run #26280529239

Builds: Windows change, Windows baseline, macOS change, macOS baseline

Framework 13 i7

Metric	Change	Baseline	Delta	Improvement
Samples	2700	2700
CPU average	33.3 ms	33.3 ms	0.0 ms	-0.0%	⚪
CPU 1% worst	33.8 ms	33.7 ms	0.1 ms	-0.2%	⚪
CPU 0.1% worst	37.1 ms	37.3 ms	-0.3 ms	0.7%	⚪
GPU average	8.0 ms	8.0 ms	-0.0 ms	0.5%	⚪
GPU 1% worst	19.7 ms	18.6 ms	1.1 ms	-5.8%	🔴
GPU 0.1% worst	29.2 ms	25.0 ms	4.2 ms	-16.8%	🔴

[mikhail-dcl]

@claude review

[claude]

Claude finished @mikhail-dcl's task in 3m 40s —— View job

---

PR Review (Re-review)

• Gather context (read CLAUDE.md, docs/README.md)
• Read changed files and full diff
• Check for blocking issues
• Post final review summary

---

Root-cause check

PASS. getPlayer() returned null in scene main() because the propagation systems only ran during Update(), one frame after the JS runtime started. The fix is structural: LocalPlayerCRDTEntityHandlerSystem.Initialize() seeds PlayerSceneCRDTEntity and SDKProfile onto PersistentEntities.Player before the runtime starts; all three writer systems have matching Initialize() overrides that force-flush CRDT messages; and PlayerCRDTEntitiesHandlerSystem now accepts SceneState.Starting so the global entity tracks the scene before it transitions to Running. This fixes the root cause, not a symptom.

---

No blocking issues

The latest synchronize trigger added only dev-merge commits (e8dd6f9f, 7173eeae) — the feature code itself is unchanged since the last review. All prior blocking issues were resolved:

• All three writer systems have Initialize() overrides calling their queries with force=true ✅
• LocalPlayerCRDTEntityHandlerSystem registered first in MultiplayerPlugin.InjectToWorld, [UpdateBefore] on all three writer systems guarantees seeding order ✅
• PlayerCRDTEntitiesHandlerSystem accepts SceneState.Starting and reuses PersistentEntities.Player for the local player ✅
• RemovePlayerFromScene early-returns for local player (crdtEntity.Id == SpecialEntitiesID.PLAYER_ENTITY), gates remote-player cleanup on Running or Starting ✅
• PlayerProfileDataPropagationSystem gains [None(typeof(PlayerComponent))] excluding the local player from the global propagation path ✅
• Tests updated correctly: AssignPlayerWhenSceneIsStarting, KeepPlayerAssignedWhenSceneTransitionsFromStartingToRunning, RemovePlayerCRDTEntityForPlayersLeavingScene, ChangeSceneOnPlayerMove — all branched on isMainPlayer ✅
• SeedPlayerCRDTEntityAndProfile and NotSeedWhenPlayerHasNoProfile cover both Initialize() paths ✅

---

Non-blocking observations (unchanged from previous review)

CharacterDataPropagationUtility.PropagateGlobalPlayerToScenePlayer (CharacterDataPropagationUtility.cs:27) is dead production code — its only caller is the test SeedLocalPlayerCRDTSystemShould. It contains an unguarded World.Add:

sceneFacade.EcsExecutor.World.Add(targetEntity, new PlayerSceneCRDTEntity(SpecialEntitiesID.PLAYER_ENTITY));

If a production caller is ever added, this will throw because LocalPlayerCRDTEntityHandlerSystem.Initialize() already seeded the component. Should be deleted or converted to AddOrSet. No immediate risk.

SeedLocalPlayerCRDTSystemShould.cs contains class LocalPlayerCRDTEntityHandlerSystemShould — file name and class name are inconsistent, which hinders discoverability.

---

REVIEW_RESULT: PASS ✅
COMPLEXITY: COMPLEX
COMPLEXITY_REASON: Touches cross-world ECS access (global ↔ scene propagation via PersistentEntities), CRDT bridge seeding order, plugin/DI wiring, scene lifecycle state machine, and system execution ordering across both global and scene worlds.
QA_REQUIRED: YES

[m3taphysics]

PR #8837, run #27268519909

Builds: Windows change, Windows baseline, macOS change, macOS baseline

How to read this table

• Each build is measured 3 times. The values are the median, and (min–max) is the lowest and highest of those runs — a wide range means the metric is noisy and small differences are not trustworthy.
• Δ is Change minus Baseline (a negative Δ means Change is faster).
• 🟢 faster / 🔴 slower — a real difference: larger than both 3% and the run-to-run range.
• ⚪ within noise — the difference is smaller than how much the build varies between its own runs, so it cannot be told apart from random variation. Treat it as no change.
• Exceptions logged — exceptions found in the run logs; more than the baseline is flagged 🔴 even when frame times look fine.

Framework 13 i7

Metric	Baseline	Change	Δ	Result
Samples	2701 (×3)	2701 (×3)
CPU average	33.3 ms	33.3 ms	-0.0 ms	⚪ within noise
CPU 1% worst	33.8 ms (33.5–34.5)	33.6 ms (33.5–34.0)	-0.2 ms	⚪ within noise
CPU 0.1% worst	38.5 ms (34.3–47.1)	35.7 ms (35.1–39.8)	-2.8 ms	⚪ within noise
GPU average	7.7 ms (7.6–7.8)	7.5 ms (7.5–8.1)	-0.1 ms	⚪ within noise
GPU 1% worst	20.1 ms (18.6–21.3)	19.5 ms (18.8–20.7)	-0.5 ms	⚪ within noise
GPU 0.1% worst	27.0 ms (25.3–28.8)	25.3 ms (24.2–26.1)	-1.7 ms	⚪ within noise
Exceptions logged	44	12	-32	🟢 fewer errors