fix: don't pre-select owned NAME dropdown entry for an unclaimed matching display name - #9609
Open
alejandro-jimenez-dcl wants to merge 1 commit into
Open
fix: don't pre-select owned NAME dropdown entry for an unclaimed matching display name#9609alejandro-jimenez-dcl wants to merge 1 commit into
alejandro-jimenez-dcl wants to merge 1 commit into
Conversation
…hing display name The claimed-name dropdown pre-selected an entry whenever its text matched profile.Name, even when profile.HasClaimedName was false. TMP_Dropdown never fires onValueChanged when re-clicking the already-selected entry, so Save could never be enabled for a user whose non-unique display name matched a newly minted NAME — a silent, 100% reproducible equip block. Only pre-select when the profile actually has a claimed name; otherwise start on the placeholder (-1) so the matching entry stays selectable. Fixes #9550 Includes a regression test that fails without this fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Contributor
|
Warnings not reduced: 13940 => 13946 — remove at least 7 warnings to merge. Warnings/errors in files changed by this PR (6) |
mikhail-dcl
approved these changes
Aug 5, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The claimed-name dropdown pre-selected an entry whenever its text matched profile.Name, even when profile.HasClaimedName was false. TMP_Dropdown never fires onValueChanged when re-clicking the already-selected entry, so Save could never be enabled for a user whose non-unique display name matched a newly minted NAME — a silent, 100% reproducible equip block.
Only pre-select when the profile actually has a claimed name; otherwise start on the placeholder (-1) so the matching entry stays selectable.
Fixes #9550
Includes a regression test that fails without this fix.
Pull Request Description
What does this PR change?
Test Instructions
Steps (standard run):
metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Steps (fresh account):
metaforge account create --clear metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Automation (if applicable):
metaforge explorer test XXXXPrerequisites
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.