fix: use scene spawn point when Events jump-in targets the scene base - #9611
Open
alejandro-jimenez-dcl wants to merge 1 commit into
Open
fix: use scene spawn point when Events jump-in targets the scene base#9611alejandro-jimenez-dcl wants to merge 1 commit into
alejandro-jimenez-dcl wants to merge 1 commit into
Conversation
EventCardActionsController.JumpInEvent unconditionally passes landOnParcel: true, which targets the raw parcel center instead of the scene's authored scene.json spawn point. This was intentional for sub-parcel targeting in multi-parcel scenes (PR #8942, e.g. a Theatre inside Genesis Plaza), but it also fires when the event's coordinates equal the scene's own base parcel, where the sub-parcel rationale doesn't apply, causing map/chat and Events-page jump-ins to the same scene to land at different positions. Clear landOnParcel in TeleportController.TeleportAsync when the requested parcel equals sceneDef.metadata.scene.DecodedBase, so the flow falls through to the same spawn-point resolution (including the cameraTarget look-at) used by every other teleport entry point. Sub-parcel jump-ins are untouched. Fixes #9546 Related: #9368 Includes a regression test that fails without this fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mikhail-dcl
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventCardActionsController.JumpInEvent unconditionally passes landOnParcel: true, which targets the raw parcel center instead of the scene's authored scene.json spawn point. This was intentional for sub-parcel targeting in multi-parcel scenes (PR #8942, e.g. a Theatre inside Genesis Plaza), but it also fires when the event's coordinates equal the scene's own base parcel, where the sub-parcel rationale doesn't apply, causing map/chat and Events-page jump-ins to the same scene to land at different positions.
Clear landOnParcel in TeleportController.TeleportAsync when the requested parcel equals sceneDef.metadata.scene.DecodedBase, so the flow falls through to the same spawn-point resolution (including the cameraTarget look-at) used by every other teleport entry point. Sub-parcel jump-ins are untouched.
Fixes #9546
Related: #9368
Includes a regression test that fails without this fix.
Pull Request Description
What does this PR change?
Test Instructions
Steps (standard run):
metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Steps (fresh account):
metaforge account create --clear metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Automation (if applicable):
metaforge explorer test XXXXPrerequisites
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.