fix: loading screen icons & images corrections - #9619
Conversation
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
decentraland-bot
left a comment
decentraland-bot
left a comment
There was a problem hiding this comment.
Review — PR #9619: fix: loading screen icons & images corrections
STEP 1 — Scope
No C# code is touched. The diff contains only:
- 2 new files —
CameraIcn.png(LFS, 805 B) + its.meta(standard UI-sprite import settings:spriteMode: 1,textureType: 8, mipmaps off) - 2 replaced textures —
LiveNow.png(≈1.11 → 1.19 MB) andTakeShot.png(≈1.30 → 1.29 MB), both via LFS pointer swap - 2 prefab edits —
TipTakeShot.prefabandTipYourPeople.prefab(sprite references, icon sizes, positions)
No systems, no components, no runtime logic. No neighbouring files need inspection.
STEP 2 — Root-cause check: PASS
The PR aligns loading-screen assets with updated Figma designs. The changes directly update the visuals — no symptom-level workaround.
STEP 3 — Design & integration: N/A
No new code units, systems, managers, or lifecycle owners introduced. Pure asset swap — design check does not apply.
STEP 4 — Member audit: N/A
No public properties or accessors changed.
STEP 5 — Line-level review
GUID cross-reference check:
CameraIcn.png.metadeclares GUID9f225046deabd4ea1bcec48a6ebb0a8f→TipTakeShot.prefabline 22 correctly references this GUID as the new sprite. ✔TipYourPeople.prefabupdates its sprite to GUID8be81fdf59a094b458426c66803c47e3— a different, pre-existing texture (not the new CameraIcn). Consistent with different tips using different icons. ✔
Layout adjustments:
TipTakeShot: icon resized to 57×57, repositioned (x: 33→30, y: ≈0). The y-value−0.0000017881is Unity floating-point serialization noise — effectively zero. ✔TipYourPeople: icon resized 45×45 → 50×50, repositioned (x: 33→33.9). ✔
Texture import settings (CameraIcn.png.meta):
enableMipMap: 0— correct for a small UI icon (805 B source). ✔spriteMode: 1(Single),textureType: 8(Sprite) — standard UI sprite config. ✔maxTextureSize: 2048— fine; the source image is tiny so this cap never activates. ✔
Security review: No code changes, no secrets, no auth flows, no API surfaces. Clean.
No P0, P1, or P2 issues found.
STEP 6 — Complexity: SIMPLE
Asset-only changes — no C# code, no ECS, no runtime logic.
STEP 7 — QA: YES
Loading-screen visuals are user-facing and need manual verification against the Figma reference.
STEP 8 — Non-blocking warnings
None. Main.unity is not modified.
REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Asset-only changes to loading-screen textures and prefab layout — no runtime code touched.
QA_REQUIRED: YES
Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
All Unity tests passed ✅
|
|
No C# files changed — lint ratchet skipped. |
|
✅ PR reviewed and approved by QA on both platforms following the PR test instructions. Screens and order of screens matches the Figma for:
MacOS: new user 05.08.2026_16.37.32_REC.9619.Mac.new.user.mp4returning user 05.08.2026_17.13.35_REC.returning.user.mp4Windows new user 05.08.2026_17.05.27_REC.new.user.mp4returning user 05.08.2026_17.12.13_REC.returning.user.mp4 |
3 participants
What does this PR change?
Complies with latest changes on loading screen designs: https://www.figma.com/design/jjNmP9Z9pdw5fgg10Fg5W7/Product?node-id=5146-2&p=f&t=NeiBAjayGZIU2Q7G-0
Test instructions
Check loading screens are shown as figma, either for new users or returning users.
To check new users you need to delete the
userdata_{n}files located at~/Library/Application Support/Decentraland/ExplorerQuality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.