Skip to content

chore: UCB write-probe throwaway (safe to delete) - #9668

Open
dalkia wants to merge 1 commit into
devfrom
sec/ucb-write-probe-throwaway
Open

chore: UCB write-probe throwaway (safe to delete)#9668
dalkia wants to merge 1 commit into
devfrom
sec/ucb-write-probe-throwaway

Conversation

@dalkia

@dalkia dalkia commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Throwaway PR for an authorized Unity Cloud Build write-authorization security probe. Do not merge; safe to close/delete at any time.

@dalkia
dalkia requested review from a team as code owners August 10, 2026 11:06
@github-actions

github-actions Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

🚦 CI Status

Build

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit df6507e
Logs https://github.com/decentraland/unity-explorer/actions/runs/31382021019
Download Windows https://github.com/decentraland/unity-explorer/suites/85116716064/artifacts/9061241447
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/sec/ucb-write-probe-throwaway/pr-24765-df6507e/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/85116716064/artifacts/9061099698
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/sec/ucb-write-probe-throwaway/pr-24765-df6507e/Decentraland_macos.zip
Built on 2026-08-10T11:44:44Z

Lint

Lint did not finish (failure) — the warning ratchet could not be evaluated. See logs.

Tests

⚠️ EditMode produced no results — the run likely crashed or timed out before finishing. Check the Unity Test / Test (editmode) job.

TESTS SUITE Result Passed Failed Skipped
EditMode ⚠️ No results
PlayMode ✅ Passed 236 0 5

@decentraland-bot
decentraland-bot self-requested a review August 10, 2026 11:06

@decentraland-bot decentraland-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review — chore: UCB write-probe throwaway (safe to delete)

Step 1 — Context & Scope

The diff adds a single new file:

  • Explorer/UCB_WRITE_PROBE_THROWAWAY.md — one line of text describing this as a throwaway write-authorization security probe.

No C# code, no Unity assets, no runtime changes. The PR description explicitly states: "Do not merge; safe to close/delete at any time."

Step 2 — Root-cause check

This PR is not solving a code problem — it is an authorized security probe testing Unity Cloud Build write-authorization. No symptom/cause analysis applies.

Result: N/A

Step 3 — Design & integration

No code units introduced. No systems, components, managers, or lifecycle logic. Nothing to trace.

Result: N/A

Step 4 — Member audit

No public members added or changed.

Result: N/A

Step 5 — Line-level review

No code to review. The single added line is a plain-text description in a markdown file. No bugs, no security issues, no performance concerns, no resource leaks.

Findings: None

Step 6 — Complexity assessment

One new markdown file, one line of text, zero code changes.

Step 7 — QA assessment

No runtime code affected. No user-facing behavior changed.

Step 8 — Non-blocking warnings

None. Main scene not modified.

Step 9 — Verdict

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: Single markdown file addition with no code or runtime impact.
QA_REQUIRED: NO


Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved based on Jarvis review — simple fix/chore with no blocking issues. No QA needed (non-runtime changes only).

@github-actions github-actions Bot added the no QA needed Used to tag pull requests that does not require QA validation label Aug 10, 2026
@decentraland-bot

This comment has been minimized.

@decentraland-bot

This comment has been minimized.

@decentraland-bot

This comment has been minimized.

@decentraland-bot

Copy link
Copy Markdown
Contributor

PR #9668, run #31502206531

Builds: Windows change, Windows baseline, macOS change, macOS baseline

How to read this table
  • Each build is measured 3 times. The values are the median, and (min–max) is the lowest and highest of those runs — a wide range means the metric is noisy and small differences are not trustworthy.
  • Δ is Change minus Baseline (a negative Δ means Change is faster).
  • 🟢 faster / 🔴 slower — a real difference: larger than both 3% and the run-to-run range.
  • ⚪ within noise — the difference is smaller than how much the build varies between its own runs, so it cannot be told apart from random variation. Treat it as no change.
  • Exceptions per run — the average number of exceptions in a run's log; more than the baseline is flagged 🔴 even when frame times look fine. The Exception breakdown under each table groups them by the explorer's report category and exception type (as totals across the runs).
  • A run that logged unusually many exceptions (at least 10 and 5× the median of its build's runs — e.g. a service was down during it) is excluded from all numbers and called out under the table.

Intel Core i5

Metric Baseline Change Δ Result
Samples 2701 (×3) 2346 (×3)
CPU average 33.2 ms 38.2 ms (36.4–38.5) 5.0 ms 🔴 15% slower
CPU 1% worst 33.5 ms (33.5–33.6) 321.1 ms (310.7–355.5) 287.6 ms 🔴 858% slower
CPU 0.1% worst 35.1 ms (34.7–35.7) 331.8 ms (328.6–389.7) 296.7 ms 🔴 844% slower
GPU average 8.2 ms (8.1–8.3) 8.0 ms (7.9–8.2) -0.2 ms ⚪ within noise
GPU 1% worst 18.3 ms (18.0–18.3) 19.1 ms (19.0–19.1) 0.8 ms 🔴 4% slower
GPU 0.1% worst 18.8 ms 19.5 ms (19.5–19.5) 0.6 ms 🔴 3% slower
Exceptions per run 66 66 0 ⚪ none new
Exception breakdown
Exception Baseline (3 runs) Change (3 runs)
[UI] DllNotFoundException 192 192
[ENGINE] NullReferenceException 3 3
[ENGINE] ObjectDisposedException 3 3

Apple M1

Metric Baseline Change Δ Result
Samples 3442 (×3) 4110 (×3)
CPU average 26.0 ms (21.5–26.4) 21.8 ms (21.6–23.4) -4.2 ms ⚪ within noise
CPU 1% worst 194.2 ms (187.6–229.9) 229.7 ms (189.2–230.6) 35.5 ms ⚪ within noise
CPU 0.1% worst 234.4 ms (232.0–237.4) 237.9 ms (233.4–238.1) 3.5 ms ⚪ within noise
GPU average 40.9 ms (30.6–41.4) 31.1 ms (30.1–33.9) -9.8 ms ⚪ within noise
GPU 1% worst 43.5 ms (34.0–43.6) 34.5 ms (34.2–38.0) -9.1 ms ⚪ within noise
GPU 0.1% worst 43.8 ms (35.0–45.1) 35.9 ms (35.8–38.2) -7.8 ms ⚪ within noise
Exceptions per run 0 0 0 ⚪ none new

@anicalbano
anicalbano removed request for a team and Ludmilafantaniella August 11, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claude-approved no QA needed Used to tag pull requests that does not require QA validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants