Skip to content

chore: update old marketplace links with shop links - #9691

Merged
davidejensen merged 4 commits into
devfrom
fix/update-shop-links
Aug 12, 2026
Merged

chore: update old marketplace links with shop links#9691
davidejensen merged 4 commits into
devfrom
fix/update-shop-links

Conversation

@davidejensen

Copy link
Copy Markdown
Member

Pull Request Description

What does this PR change?

Fix #9690
Update links to redirect to new shop instead of old marketplace

Test Instructions

Test Steps

  1. Open the client
  2. Click in the sidebar on the marketplace link and verify it opens the browser on the new shop

Additional Testing Notes

  • Note any edge cases to verify
  • Mention specific areas that need careful testing
  • List known limitations or potential issues

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.

@davidejensen davidejensen self-assigned this Aug 12, 2026
@davidejensen
davidejensen requested review from a team as code owners August 12, 2026 08:17
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚦 CI Status

Build

Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below.

Name Link
Commit cb6fca8
Logs https://github.com/decentraland/unity-explorer/actions/runs/31582702208
Download Windows https://github.com/decentraland/unity-explorer/suites/85670425939/artifacts/9136981814
Download Windows S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/update-shop-links/pr-24864-cb6fca8/Decentraland_windows64.zip
Download Mac https://github.com/decentraland/unity-explorer/suites/85670425939/artifacts/9136778028
Download Mac S3 https://explorer-artifacts.decentraland.org/@dcl/unity-explorer/branch/fix/update-shop-links/pr-24864-cb6fca8/Decentraland_macos.zip
Built on 2026-08-12T10:04:35Z

Lint

Warnings count reduced: 13653 => 13648

Warnings/errors in files changed by this PR (7)
Assets/DCL/Passport/Modules/EquippedItemsPassportModuleController.cs:61  CSharpWarnings::CS8618  Non-nullable fields 'currentProfile', 'getEquippedItemsCts' must contain non-null values when exiting constructor. Consider adding the 'required' modifiers or declaring the fields as nullable.
Assets/DCL/Backpack/AvatarSection/AvatarController.cs:86  ConditionalAccessQualifierIsNonNullableAccordingToAPIContract  Conditional access qualifier expression is never null according to nullable reference types' annotations
Assets/DCL/Backpack/AvatarSection/AvatarController.cs:87  ConditionalAccessQualifierIsNonNullableAccordingToAPIContract  Conditional access qualifier expression is never null according to nullable reference types' annotations
Assets/DCL/Backpack/AvatarSection/AvatarController.cs:88  ConditionalAccessQualifierIsNonNullableAccordingToAPIContract  Conditional access qualifier expression is never null according to nullable reference types' annotations
Assets/DCL/Backpack/AvatarSection/AvatarController.cs:89  ConditionalAccessQualifierIsNonNullableAccordingToAPIContract  Conditional access qualifier expression is never null according to nullable reference types' annotations
Assets/DCL/PluginSystem/Global/SidebarPlugin.cs:48  InconsistentNaming  Name 'mainUIView' does not match rule 'non_public_members_should_be_camel_case'. Suggested name is 'mainUiView'.
Assets/DCL/PluginSystem/Global/SidebarPlugin.cs:89  InconsistentNaming  Name 'mainUIView' does not match rule 'parameters_should_be_camel_case'. Suggested name is 'mainUiView'.

Tests

All Unity tests passed ✅

TESTS SUITE Result Passed Failed Skipped
EditMode ✅ Passed 24607 0 13
PlayMode ✅ Passed 236 0 5

@decentraland-bot
decentraland-bot self-requested a review August 12, 2026 08:18

@decentraland-bot decentraland-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review — PR #9691: chore: update old marketplace links with shop links

STEP 2 — Root-cause check

PASS. The PR correctly addresses the root cause: the old marketplace domain/URLs need to be replaced with the new shop domain/URLs. DecentralandUrl.ShopLink already exists (maps to https://decentraland.{ENV}/shop) and the /item/{contract}/{item} path pattern is already used in EquippedItemsPassportModuleController.cs, confirming this is the correct target.

STEP 3 — Design & integration

PASS. No new units introduced — pure URL enum swaps and a UI label rename. No lifecycle management, no state, no subscriptions. The existing IDecentralandUrlsSource pattern is correctly reused.

STEP 4 — Member audit

No new public properties or accessors. Existing method signatures are unchanged. N/A.

STEP 5 — Line-level review

See inline comments below. One P2 naming finding.

Completeness note: Two other files still reference DecentralandUrl.Market and likely need the same migration:

  • Explorer/Assets/DCL/Backpack/AvatarSection/AvatarController.cs
  • Explorer/Assets/DCL/Passport/Modules/Creations/CreationsDetailsPassportModuleController.cs

Since the PR title says "update old marketplace links with shop links", consider including these in this PR or tracking them as a follow-up to fully complete the migration.

STEP 5b — Security review

No security issues found. URL domains are resolved from an internal enum (DecentralandUrl.ShopLink), not from user input. No secrets, no injection surfaces, no auth changes.

STEP 6 — Complexity

SIMPLE. Touches 3 files with ~6 lines of meaningful changes, all straightforward string/URL swaps and a label rename.

STEP 7 — QA assessment

QA_REQUIRED: YES. Changes runtime code that affects what the user sees (sidebar button label "Marketplace" → "Shop") and where links navigate (old marketplace → new shop).

STEP 8 — Non-blocking warnings

None.

STEP 9 — Verdict

REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: URL string/label swaps in 2 C# files and 1 UI prefab — no logic, no ECS, no async
QA_REQUIRED: YES


Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub

Comment thread Explorer/Assets/DCL/InWorldCamera/PhotoDetail/PhotoDetailUtility.cs Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved based on Jarvis review — simple fix/chore with no blocking issues. QA approval is still required.

@davidejensen
davidejensen enabled auto-merge (squash) August 12, 2026 08:26

@DafGreco DafGreco left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • [✔️ ] Log In/Log Out
  • [✔️ ] Backpack and wearables in world
  • [✔️ ] Emotes in world and in backpack
  • [✔️ ] Teleport with map/coordinates/Jump In
  • [✔️ ] Chat and multiplayer

Evidence

20260812-1006-03.3836989.mp4

@davidejensen
davidejensen merged commit 26aabdd into dev Aug 12, 2026
23 of 25 checks passed
@davidejensen
davidejensen deleted the fix/update-shop-links branch August 12, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change marketplace links for new shop link

3 participants