chore: update old marketplace links with shop links - #9691
Conversation
🚦 CI StatusWindows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. Warnings count reduced: 13653 => 13648 Warnings/errors in files changed by this PR (7)All Unity tests passed ✅
|
decentraland-bot
left a comment
There was a problem hiding this comment.
Review — PR #9691: chore: update old marketplace links with shop links
STEP 2 — Root-cause check
PASS. The PR correctly addresses the root cause: the old marketplace domain/URLs need to be replaced with the new shop domain/URLs. DecentralandUrl.ShopLink already exists (maps to https://decentraland.{ENV}/shop) and the /item/{contract}/{item} path pattern is already used in EquippedItemsPassportModuleController.cs, confirming this is the correct target.
STEP 3 — Design & integration
PASS. No new units introduced — pure URL enum swaps and a UI label rename. No lifecycle management, no state, no subscriptions. The existing IDecentralandUrlsSource pattern is correctly reused.
STEP 4 — Member audit
No new public properties or accessors. Existing method signatures are unchanged. N/A.
STEP 5 — Line-level review
See inline comments below. One P2 naming finding.
Completeness note: Two other files still reference DecentralandUrl.Market and likely need the same migration:
Explorer/Assets/DCL/Backpack/AvatarSection/AvatarController.csExplorer/Assets/DCL/Passport/Modules/Creations/CreationsDetailsPassportModuleController.cs
Since the PR title says "update old marketplace links with shop links", consider including these in this PR or tracking them as a follow-up to fully complete the migration.
STEP 5b — Security review
No security issues found. URL domains are resolved from an internal enum (DecentralandUrl.ShopLink), not from user input. No secrets, no injection surfaces, no auth changes.
STEP 6 — Complexity
SIMPLE. Touches 3 files with ~6 lines of meaningful changes, all straightforward string/URL swaps and a label rename.
STEP 7 — QA assessment
QA_REQUIRED: YES. Changes runtime code that affects what the user sees (sidebar button label "Marketplace" → "Shop") and where links navigate (old marketplace → new shop).
STEP 8 — Non-blocking warnings
None.
STEP 9 — Verdict
REVIEW_RESULT: PASS ✅
COMPLEXITY: SIMPLE
COMPLEXITY_REASON: URL string/label swaps in 2 C# files and 1 UI prefab — no logic, no ECS, no async
QA_REQUIRED: YES
Reviewed by Jarvis 🤖 · Requested by decentraland-bot via GitHub
DafGreco
left a comment
There was a problem hiding this comment.
✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path
Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- [✔️ ] Log In/Log Out
- [✔️ ] Backpack and wearables in world
- [✔️ ] Emotes in world and in backpack
- [✔️ ] Teleport with map/coordinates/Jump In
- [✔️ ] Chat and multiplayer
Evidence
Pull Request Description
What does this PR change?
Fix #9690
Update links to redirect to new shop instead of old marketplace
Test Instructions
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.