chore(ci): link Unity Cloud builds, test reports, timings, performance and automation from the CI status comment #9713
+1,981
−205
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -61,6 +61,13 @@ def _extract_member(self, member, targetpath, pwd): | |||||
|
|
||||||
| build_healthy = True | ||||||
|
|
||||||
| # Deep link to this build in the Unity Cloud dashboard, captured from the first build | ||||||
| # response that carries one. Persisted to BUILD_LINK_INFO_PATH so the workflow can | ||||||
| # upload it and the PR status comment can link the build directly. | ||||||
| BUILD_LINK_INFO_PATH = 'unity_cloud_build_info.env' | ||||||
| dashboard_url = None | ||||||
| _build_link_info_written = False | ||||||
|
|
||||||
| parser = argparse.ArgumentParser() | ||||||
| parser.add_argument('--resume', help='Resume tracking a running build stored in build_info.json', action='store_true') | ||||||
| parser.add_argument('--cancel', help='Cancel a running build stored in build_info.json', action='store_true') | ||||||
|
|
@@ -616,6 +623,44 @@ def try_resume_build(): | |||||
| return None | ||||||
|
|
||||||
|
|
||||||
| def record_build_link_info(id, response_json): | ||||||
| """Persist the Unity Cloud dashboard deep link for this build (best-effort). | ||||||
|
|
||||||
| Build API responses carry dashboard links; the workflow uploads the written file | ||||||
| as an artifact so the PR status comment can link the build id directly instead | ||||||
| of telling humans to search cloud.unity.com by hand. | ||||||
| """ | ||||||
| global dashboard_url, _build_link_info_written | ||||||
|
|
||||||
| links = response_json.get('links') or {} | ||||||
| href = None | ||||||
| # dashboard_summary is the build's page and dashboard_log its log tab; | ||||||
| # dashboard_url can be just the dashboard root, so a candidate only | ||||||
| # qualifies when it points at this specific build. | ||||||
| for key in ('dashboard_summary', 'dashboard_log', 'dashboard_url'): | ||||||
| candidate = (links.get(key) or {}).get('href') | ||||||
| if candidate and '/builds/' in candidate: | ||||||
|
Contributor
There was a problem hiding this comment. The Downstream that produces a broken
Suggested change
|
||||||
| href = candidate | ||||||
| break | ||||||
|
|
||||||
| if _build_link_info_written and not href: | ||||||
| return | ||||||
|
|
||||||
| try: | ||||||
| with open(BUILD_LINK_INFO_PATH, 'w') as f: | ||||||
| f.write(f'BUILD_TARGET={os.getenv("TARGET")}\n') | ||||||
| f.write(f'BUILD_ID={id}\n') | ||||||
| if href: | ||||||
| f.write(f'DASHBOARD_URL={href}\n') | ||||||
| except OSError as e: | ||||||
| print(f'Warning: could not write {BUILD_LINK_INFO_PATH}: {e}') | ||||||
|
|
||||||
| if href: | ||||||
| dashboard_url = href | ||||||
| print(f'::notice::Unity Cloud build #{id} ({os.getenv("TARGET")}): {href}') | ||||||
| _build_link_info_written = True | ||||||
|
|
||||||
|
|
||||||
| def write_step_summary(target, build_id, final_status, phase_durations, queue_reasons, queue_elapsed, build_elapsed): | ||||||
| """Append a phase breakdown to $GITHUB_STEP_SUMMARY (best-effort).""" | ||||||
| summary_path = os.environ.get('GITHUB_STEP_SUMMARY') | ||||||
|
|
@@ -635,6 +680,8 @@ def fmt(seconds): | |||||
| lines.append('') | ||||||
| lines.append(f'- Target: `{target}`') | ||||||
| lines.append(f'- Build ID: `{build_id}`') | ||||||
| if dashboard_url: | ||||||
| lines.append(f'- Unity Cloud build page: {dashboard_url}') | ||||||
| lines.append(f'- Final outcome: `{final_status}`') | ||||||
| if queue_reasons: | ||||||
| lines.append(f"- Queue reasons seen: {', '.join(f'`{r}`' for r in sorted(queue_reasons))}") | ||||||
|
|
@@ -711,6 +758,9 @@ def run_poll_loop(id, build_already_active=False, resumed_build_elapsed=0): | |||||
|
|
||||||
| keep_polling, status, response_json = poll_build(id) | ||||||
|
|
||||||
| if dashboard_url is None: | ||||||
| record_build_link_info(id, response_json) | ||||||
|
|
||||||
| queued_reason = response_json.get('queuedReason') | ||||||
| if queued_reason and status in QUEUE_STATUSES: | ||||||
| queue_reasons.add(queued_reason) | ||||||
|
|
@@ -920,7 +970,8 @@ def probe_latest_build(): | |||||
| download_log(id) | ||||||
|
|
||||||
| if not build_healthy: | ||||||
| where = dashboard_url or f'https://cloud.unity.com/ (search for target "{os.getenv("TARGET")}" and build ID "{id}")' | ||||||
| print(f'Build unhealthy - check the downloaded logs or the Unity Cloud build page: {where}') | ||||||
| sys.exit(1) | ||||||
|
|
||||||
| # Cleanup (only if build is healthy and not release) | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-ranis consumed by three jobs, and widening it here changes the meaning for all of them, not just the failure path this PR is targeting:comment-failed— the intended fix. ✅comment-skipped(L98,build-ran == 'false') andcomment-success(L121,== 'true') — these split on the same flag.comment-successthen looks upDecentraland_windows64/Decentraland_macosids and interpolates them into download URLs. Before this change,build-ran == 'true'guaranteed at least oneDecentraland_*artifact existed; now a run whose conclusion issuccesswith onlyunity_build_info_*present posts "Windows and Mac build successful!" with…/artifacts/(empty id) links.For an honest in-repo build that combination is hard to reach, but a fork PR controls its own copy of
build-unitycloud.ymland can upload an arbitrarily-named artifact, so it's reachable on demand.Suggest emitting two outputs and keeping the success/skipped split on the narrower one:
…with
comment-success/comment-skippedgating onplayer-artifactsandcomment-failedonbuild-ran.