fix: add missing road parcels to the baked road data - #9779
Closed
alejandro-jimenez-dcl wants to merge 1 commit into
Closed
fix: add missing road parcels to the baked road data#9779alejandro-jimenez-dcl wants to merge 1 commit into
alejandro-jimenez-dcl wants to merge 1 commit into
Conversation
RoadData.asset and SingleParcelRoadInfo.json are missing entries for 15 road parcels that exist in the deployed catalyst road scenes, leaving holes in the Genesis City road network; no fallback can cover them because the deployed scenes there are SDK6 with no LOD bundles. Bake the recovered models and rotations in. Fixes #3279 Related: #3477 Includes a regression test that fails without this fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
already fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoadData.asset and SingleParcelRoadInfo.json are missing entries for 15 road parcels that exist in the deployed catalyst road scenes, leaving holes in the Genesis City road network; no fallback can cover them because the deployed scenes there are SDK6 with no LOD bundles. Bake the recovered models and rotations in.
Fixes #3279
Related: #3477
Includes a regression test that fails without this fix.
Pull Request Description
What does this PR change?
Test Instructions
Steps (standard run):
metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Steps (fresh account):
metaforge account create --clear metaforge explorer run XXXX # ← replace with this PR numberExpected result:
Automation (if applicable):
metaforge explorer test XXXXPrerequisites
Test Steps
Additional Testing Notes
Quality Checklist
Code Review Reference
Please review our Branch & PR Standards before submitting. It explains the automated review flow, QA/DEV approval requirements, and what each label does — especially useful for first-time contributors.