fix: reject non-NumericDate exp, nbf, and iat claims - #337
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verifyJWTtreatedexp,nbf, andiatas present only when they were truthy.exp: 0and string values such as"never"skipped the RFC 7519 NumericDate window while the signature still verified.exp: 0is expired (1970-01-01). Missing claims stay optional, matching the existing policy flags.policies.nowon the hardcoded did:key VC. That fixture expired on 2025-12-04 and already failed on tip.Test plan
yarn test326/326yarn lintThreat-model: the signer already controls the payload. The remaining verifier guard is the validity window. A present non-NumericDate claim turned that guard into a no-op.