Updated status and version. - #115
Merged
Merged
Conversation
…ironment by Unmio platform Signed-off-by: Jorge Flores <jorge@entidad.io>
TheTechmage
approved these changes
Sep 22, 2025
TheTechmage
left a comment
TheTechmage
left a comment
Member
There was a problem hiding this comment.
Discussed in UG meeting 20250922
Meets the requirements for demonstration, would love to see a demo of the protocol in action!
Contributor
Author
|
hi @TheTechmage Any idea what is preventing this PR from getting merged? It has already been approved. |
Member
|
I believe we were hoping for a demo before approval, but it wasn't a hard requirement before merging. |
Contributor
Author
|
I can demo to the group but I agree the PR merge should not be contingent on that. I have taken a look at the PR validation error but have no idea how to resolve it on my end. Any thoughts? |
Member
|
That error does not look related to your change. I can review the validation rules to see what's actually tripping it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol is implemented in production environment by Unmio platform