fix: prevent decibri play from hanging on device loss or Ctrl+C - #32
Merged
Conversation
rossarmstrong
commented
Jul 11, 2026
rossarmstrong
commented
Member
- src/commands/play.rs: run the blocking send loop and the EOF drain on a feeder thread holding a SpeakerSink, with the main thread owning the SpeakerStream and orchestrating shutdown; stop() the stream on Ctrl+C and on observed device failure (is_playing() false) so a parked send or drain is released, the device is freed, and playback ends deterministically (exit 0 on interrupt, exit 4 on device loss, exit 0 on normal EOF)
- README.md: exit-code 4 now covers device loss mid-playback as well as mid-capture
- CHANGELOG.md: Unreleased entry for the play hang fix
- src/commands/play.rs: run the blocking send loop and the EOF drain on a feeder thread holding a SpeakerSink, with the main thread owning the SpeakerStream and orchestrating shutdown; stop() the stream on Ctrl+C and on observed device failure (is_playing() false) so a parked send or drain is released, the device is freed, and playback ends deterministically (exit 0 on interrupt, exit 4 on device loss, exit 0 on normal EOF) - README.md: exit-code 4 now covers device loss mid-playback as well as mid-capture - CHANGELOG.md: Unreleased entry for the play hang fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.