Modules type and description - #366
Conversation
✅ Deploy Preview for decidim-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello, @andreslucena! Can you review this PR? |
|
Hi @luizsanches Thanks for the PR! I didn't add the i18n for these descriptions because I didn't realize and I wanted to manage them by using https://decapcms.org/ (formerly known as Netlify CMS), with the idea of making it more easy for other people to contribute here. That wasn't the case, as I think like 99% of the modules were added by me 😅 - So, I'd be happy to merge this and make these descriptions compatible with i18n I'll try to allocate time tomorrow to check this out, but if I don't have time then I'd probably do it next week (as Thursday and Friday are holidays here). |
|
That's great, @andreslucena! I look forward to your suggestions. |
|
The differences I could detect are good things:
Are there more things to mention @luizsanches ? |
andreslucena
left a comment
There was a problem hiding this comment.
Apart from my question about the differences, a couple things that we need before merging:
- Seems like titles are broken, can you fix it 🙏🏽 ?
- As we're moving the description to the i18n system, we should remove the definition from Decap CMS:
decidim.org/source/admin/config.yml
Line 84 in f549220
Can you remove it please?
|
That's right #366 (comment)! And apologies for not sending the screenshots |
|
@andreslucena check that it's ok #366 (review) |




Hello!
Description
I realized that the descriptions of the modules were not translated and I made some adjustments with a proposal to organize the data and image files and subfolders. I also removed some modules that were duplicated.