Skip to content

Modules type and description - #366

Open
luizsanches wants to merge 5 commits into
decidim:mainfrom
luizsanches:refactor/modules-type-and-description
Open

Modules type and description#366
luizsanches wants to merge 5 commits into
decidim:mainfrom
luizsanches:refactor/modules-type-and-description

Conversation

@luizsanches

Copy link
Copy Markdown
Contributor

Hello!

Description

I realized that the descriptions of the modules were not translated and I made some adjustments with a proposal to organize the data and image files and subfolders. I also removed some modules that were duplicated.

@netlify

netlify Bot commented Apr 21, 2025

Copy link
Copy Markdown

Deploy Preview for decidim-website ready!

Name Link
🔨 Latest commit b2963a0
🔍 Latest deploy log https://app.netlify.com/sites/decidim-website/deploys/68220e3b44a07000080b9e20
😎 Deploy Preview https://deploy-preview-366--decidim-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@luizsanches luizsanches changed the title Refactor/modules type and description Modules type and description Apr 22, 2025
@luizsanches

Copy link
Copy Markdown
Contributor Author

Hello, @andreslucena! Can you review this PR?

@andreslucena

Copy link
Copy Markdown
Member

Hi @luizsanches

Thanks for the PR!

I didn't add the i18n for these descriptions because I didn't realize and I wanted to manage them by using https://decapcms.org/ (formerly known as Netlify CMS), with the idea of making it more easy for other people to contribute here. That wasn't the case, as I think like 99% of the modules were added by me 😅 - So, I'd be happy to merge this and make these descriptions compatible with i18n

I'll try to allocate time tomorrow to check this out, but if I don't have time then I'd probably do it next week (as Thursday and Friday are holidays here).

@luizsanches

Copy link
Copy Markdown
Contributor Author

That's great, @andreslucena! I look forward to your suggestions.

@andreslucena

Copy link
Copy Markdown
Member

The differences I could detect are good things:

  1. Fixing a problem with the lists and newlines, like this:
    image

  2. Changing the three calendars to the one actually maintained from decidim-ice:

image

  1. Fixing the two copies of Cleaner to only one:
    image

  2. Changing the URL of Decidim Awesome to the one actually maintained (from decidim-ice)

Are there more things to mention @luizsanches ?

@andreslucena andreslucena left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my question about the differences, a couple things that we need before merging:

  1. Seems like titles are broken, can you fix it 🙏🏽 ?

image

  1. As we're moving the description to the i18n system, we should remove the definition from Decap CMS:

- name: "Module"

Can you remove it please?

@luizsanches

Copy link
Copy Markdown
Contributor Author

That's right #366 (comment)! And apologies for not sending the screenshots

@luizsanches

Copy link
Copy Markdown
Contributor Author

@andreslucena check that it's ok #366 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants