Redesign "The Association" page - #434
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR redesigns the About page with restructured content, a new drag-to-scroll carousel for image galleries, and refreshed visual styling. The locale strings support the new layout with association membership/donation CTAs, history timeline, and updated values messaging. A carousel JavaScript module and CSS components enable horizontal image scrolling. The About template is significantly restructured with hero typography updates, mission/vision section, history timeline, partners CTA, banner image, recognitions grid, and values section redesign including rounded pill-style value tags. ChangesAbout Page and Carousel Redesign
Sequence DiagramsequenceDiagram
participant User
participant CarouselJS as carousel.js
participant DOM
User->>CarouselJS: mousedown on gallery
CarouselJS->>CarouselJS: Record drag start position
CarouselJS->>DOM: Toggle cursor (grabbing)
User->>CarouselJS: mousemove
CarouselJS->>DOM: Update scrollLeft delta
User->>CarouselJS: mouseup / mouseleave
CarouselJS->>DOM: Restore cursor (grab)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
locales/en.yml (1)
29-29: 💤 Low valueMinor grammar improvement: use present perfect tense.
The phrase "From the beginning, Decidim has a social contract" mixes temporal markers. Consider using present perfect "has had" to properly express continuity from past to present.
📝 Suggested improvement
- values_intro: Decidim is a technopolitical project that serves as a public commons infrastructure, combining institutional support with open and free code accessibility. From the beginning, Decidim has a social contract that defines the values of the project. + values_intro: Decidim is a technopolitical project that serves as a public commons infrastructure, combining institutional support with open and free code accessibility. From the beginning, Decidim has had a social contract that defines the values of the project.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@locales/en.yml` at line 29, Update the string for the YAML key values_intro to use present perfect tense ("has had") instead of "has" to indicate continuity from past to present; locate the values_intro entry in locales/en.yml and replace "Decidim has a social contract" with "Decidim has had a social contract", preserving the rest of the sentence and punctuation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@locales/en.yml`:
- Line 29: Update the string for the YAML key values_intro to use present
perfect tense ("has had") instead of "has" to indicate continuity from past to
present; locate the values_intro entry in locales/en.yml and replace "Decidim
has a social contract" with "Decidim has had a social contract", preserving the
rest of the sentence and punctuation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 15aa9144-f5ff-400c-a781-7e86cdccb0ec
⛔ Files ignored due to path filters (1)
source/images/banner_about.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
locales/en.ymlsource/localizable/about.html.erb
✅ Deploy Preview for decidim-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@andreslucena applied changes. Ready for another round |
|
Any chance we can get a second review @andreslucena? Of your comments and suggestions have long been tacked. It will block #444 |
|
I have fixed the resolution issue in 3e88c58 affecting the timeline section you mentioned Screencast.from.2026-07-17.11-06-17.webmLet me know if you're happy with the implementation criteria, so we can fix: #446 |
4 participants
NOTE: As the partners section #402 is not built yet, this PR omits one section based on the design:
Summary by CodeRabbit
Summary by CodeRabbit
Documentation
New Features
Style
Chores