Redesign "Partnership Policy" page

[greenwoodt]

• Fixes: Partnership policy (community) #404

[coderabbitai]

Warning

Review limit reached

Next included review available in 31 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 5da66de5-9adf-4501-93ca-0958f5a6b3b4

📥 Commits

Reviewing files that changed from the base of the PR and between d382621 and 546a327.

📒 Files selected for processing (1)

• locales/en.yml

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Added a “back to partners” link on the partnership policy page.

• UI/UX Changes

  • Refreshed the partnership policy page layout, typography, and list styling.
  • Simplified the partnership explanation into a single consolidated block.
  • Updated heading hierarchy and merged additional requirements copy into the existing requirements list.

• Navigation

  • Added the partnership policy page to the legal navigation menu.

Walkthrough

The partnership-policy page now uses consolidated explanation content, includes a back-to-partners link, appears in legal navigation, updates heading and text styling, and renders requirements content as a bullet list.

Changes

Partnership Policy Page Update

Layer / File(s)	Summary
Translation and page content contract locales/en.yml	Adds the back_to_partners translation and replaces nested explanation paragraphs with one consolidated string.
Page layout and content rendering source/localizable/partnership-policy.html.erb	Adds the arrow-link partial, renders the consolidated explanation, changes heading levels and styling, and moves requirements.p2 into the requirements list.
Legal navigation entry data/links.yml	Adds /partnership-policy to the legal navigation list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: andreslucena

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Matches the main change: redesigning the Partnership Policy page.
Description check	✅ Passed	The description references issue #404, which is directly tied to this page redesign.
Linked Issues check	✅ Passed	The layout, responsive styling, and content updates align with the Partnership Policy redesign requested in #404.
Out of Scope Changes check	✅ Passed	No clearly unrelated code changes are indicated beyond the page redesign and related navigation entry.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for decidim-website ready!

Name	Link
🔨 Latest commit	546a327
🔍 Latest deploy log	https://app.netlify.com/projects/decidim-website/deploys/6a969c568f98a8000846cd64
😎 Deploy Preview	https://deploy-preview-439--decidim-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@locales/en.yml`:
- Line 499: The explanation text at line 499 in locales/en.yml is missing the
URL placeholders that were previously present. Restore the `%{main_website_url}`
placeholder where the text references "Decidim main website" and the
`%{readme_url}` placeholder where it references "GitHub project README page".
These placeholders are still being provided by the template in
source/localizable/partnership-policy.html.erb at line 17, so adding them back
will ensure the URLs are properly rendered as clickable links in the policy
copy.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc874aea-04dc-4067-b99e-d360710c36fc

📥 Commits

Reviewing files that changed from the base of the PR and between 7c48b77 and 143c180.

📒 Files selected for processing (2)

• locales/en.yml
• source/localizable/partnership-policy.html.erb

[julietapasetti]

First review 'Partnership-policy'

• Change these settings on mobile

[greenwoodt]

First review 'Partnership-policy'

* [x]  Change these settings on mobile

Done

[elsa-decidim]

All good in terms of copies!

[andreslucena]

There's currently a navigation/consistency issue here. I don't know if it will be handled now or in other PR:

1. Go to this page: https://deploy-preview-439--decidim-website.netlify.app/partnership-policy/
2. Click in "Back to partners" link (/partners)
3. (First consistency issue/bug) This page now is called Supporters (it is also redirected to /supporters). New links should prefer both the new link and wording
4. (Second consistency issue/bug) In this page, I don't have any link back to "Partnership policy", the only one is "How can governments partner with us?" but that links to https://deploy-preview-439--decidim-website.netlify.app/how-to-support/ - also if that page is for government it should be consistent the title with the slug ("how-to-support" and "How governments can partner with us?" don't match, it should be something like "how-governments-partner-us")

[greenwoodt]

There's currently a navigation/consistency issue here. I don't know if it will be handled now or in other PR:

1. Go to this page: [deploy-preview-439--decidim-website.netlify.app/partnership-policy](https://deploy-preview-439--decidim-website.netlify.app/partnership-policy/)

2. Click in "Back to partners" link (/partners)

3. (First consistency issue/bug) This page now is called Supporters (it is also redirected to /supporters). New links should prefer both the new link and wording

4. (Second consistency issue/bug) In this page, I don't have any link back to "Partnership policy", the only one is "How can governments partner with us?" but that links to [deploy-preview-439--decidim-website.netlify.app/how-to-support](https://deploy-preview-439--decidim-website.netlify.app/how-to-support/)  - also if that page is for government it should be consistent the title with the slug ("how-to-support" and "How governments can partner with us?" don't match, it should be something like "how-governments-partner-us")

You're right on the redirect to "Back to partners". I guess it was due to this change e8a75b4 back in #399 when that page was originally called "Partners", although now we will now have a Partners page #440, which is very similar to how #416 is built, the wording won't change as the sprint has defined "Supporters" and "Partners"they are two separate contexts.

I would say lets pick up the review to this after #440 pages are done and #416 is merged as I require components built there to complete the CMS and index (filtering & pagination).

[greenwoodt]

@andreslucena I would say the issues of your initial review are now solved.

This is ready for another round.

[andreslucena]

Link here doesn't have styling:

[greenwoodt]

Link here doesn't have styling:

Fixed here: 57ed03f and ready for another review @andreslucena!