Retrieves Firebase Project ID from the provided service credential file - #143
Retrieves Firebase Project ID from the provided service credential file#143xavarius wants to merge 9 commits into
Conversation
|
Dear @sabman, I'm fully aware you may need some time to review this. Could you please let me know if you would have opportunity to do it like this month? :) Thanks a lot! |
|
@xavarius can you please reference the file schema in the code? Sorry for the delay on this. |
|
Also maybe we wanna do it as a non-breaking change with a deprecation warning? |
No worries. Excuse me. But What do you mean by referencing file schema in the code? |
…t name aka project id will be set from the service credentials file only if the project name wasn't provided as a part of initialisation
|
@sabman hello there, I applied both improvements and merged what was already in the origin/master branch. Could we proceed with it? Lemme know. :) |
|
We could I'm keen to hear from others about backwards compatibility given it's a breaking change. Also security perspective it would be great to confirm if google provides a schema even if undocumented? |
|
@sabman I implemented it in the way that is it not a breaking change anymore, as asked. Covered by units of course. Yeah, the undocumented schema is tricky. I wasn't able to find the documentation, as shared in the PR description. My thoughts are: |
This fixes #142
The pull request adds automatic Firebase Project ID handling by retrieving it from the provided configuration/credential file.
Since the service credential file (exported from the Firebase) contains this project ID, the PR removes duplication in the client initialization.
I would suggest releasing new version with this change, possibly major one, since it's a breaking change.
PS
I have not found any confirmed Firebase service credentials json schema, which kinda makes sense to not disclosure it, but we're all working here with assumptions around the API and file schema.