mixclient: Fix test timeouts - #3501
Merged
Merged
Conversation
Tests were timing out due to mixpool checks that require KEs to not be received too early for their stated epochs. To speed tests up, the mixclient's internal epoch ticker is manually ticked by the testing code, but this was causing test runs where KE messages were being rejected by mixpool, with the tests never completing and eventually timing out. Using the current time as the epoch whenever the internal epoch ticker is manually ticked by tests resolves the issue and allows all tests to pass. Timeouts spotted by @jholdstock.
davecgh
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were timing out due to mixpool checks that require KEs to not be received too early for their stated epochs. To speed tests up, the mixclient's internal epoch ticker is manually ticked by the testing code, but this was causing test runs where KE messages were being rejected by mixpool, with the tests never completing and eventually timing out.
Using the current time as the epoch whenever the internal epoch ticker is manually ticked by tests resolves the issue and allows all tests to pass.
Timeouts spotted by @jholdstock.