blockchain: Always check size and merkle root. - #3782
Merged
davecgh merged 1 commit intoAug 26, 2026
Conversation
jholdstock
approved these changes
Aug 23, 2026
dajohi
approved these changes
Aug 26, 2026
This modifies the assumevalid fast add path used during initial sync to also check the block size and merkle roots. These checks are now negligible in terms of the overall sync time since the hashing has been significantly optimized and retaining them prevents certain classes of potential harassment during initial sync.
davecgh
force-pushed
the
blockchain_always_check_size_and_merkleroots
branch
from
August 26, 2026 11:44
73316c2 to
ead8ba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the
assumevalidfast add path used during initial sync to also check the block size and merkle roots.These checks are now negligible in terms of the overall sync time since the hashing has been significantly optimized and retaining them prevents certain classes of potential harassment during initial sync.