stake: Correct off by one in revoke create helper. - #3784
Merged
Conversation
The helper method in the stake package for creating revocations does not currently allow zero-valued revocations even though they are valid by consensus. The error message even indicates the minimum allowed is 0. This corrects the check so it is accurate and allows zero as intended. It also adds a test to ensure proper functionality.
davecgh
force-pushed
the
stake_create_revocation_helper
branch
from
August 26, 2026 12:26
aefbcac to
5dd4ca5
Compare
jholdstock
approved these changes
Aug 27, 2026
jrick
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The helper method in the stake package for creating revocations does not currently allow zero-valued revocations even though they are valid by consensus. The error message even indicates the minimum allowed is 0.
This corrects the check so it is accurate and allows zero as intended.
It also adds a test to ensure proper functionality.