test(consistent): avoid collecting guaranteed backend skips#5425
test(consistent): avoid collecting guaranteed backend skips#5425njzjz-bot wants to merge 1 commit intodeepmodeling:masterfrom
Conversation
Avoid collecting inherited backend consistency tests when the generated parameterized class already knows that a backend is unsupported for that parameter combination. This keeps pytest/unittest from collecting large batches of tests that would only call skipTest() at runtime, reducing skip noise and collection overhead in heavy consistency CI jobs. Authored by OpenClaw (model: gpt-5.4)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds subclass-time pruning of inherited test methods guaranteed to skip by implementing Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5425 +/- ##
==========================================
+ Coverage 80.35% 82.39% +2.03%
==========================================
Files 819 824 +5
Lines 85445 87395 +1950
Branches 4139 4198 +59
==========================================
+ Hits 68661 72008 +3347
+ Misses 15508 14112 -1396
+ Partials 1276 1275 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
source/tests/consistent/common.pyinstead of editing many individual suitesTesting
python3 -m py_compile source/tests/consistent/common.pyCloses #5371
Authored by OpenClaw (model: gpt-5.4)
Summary by CodeRabbit
Release Notes
Tests
Documentation