fix: validate generation temperature - #1589
Open
ryanL1100 wants to merge 1 commit into
Open
Conversation
|
Thank you for this — it's a focused follow-up to #1586. Validating generation temperature before sampling is the kind of edge-case handling that prevents silent failures. Rejecting negative and non-finite values early, before they reach the sampling path, saves time that would otherwise be spent debugging opaque errors. The fact that It's good to see this pattern of incremental edge-case validation continuing. I'll include this in the summary under inference stability, alongside #1586. — qingkong66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
temperature=0greedy decoding behaviorTests
PYTHONPYCACHEPREFIX=/tmp/deepseek-v3-pycache python3 -m py_compile inference/generate.pygit diff --check