fix(inference): preserve index metadata when converting fp8 to bf16 - #1597
Open
loulanyue wants to merge 1 commit into
Open
fix(inference): preserve index metadata when converting fp8 to bf16#1597loulanyue wants to merge 1 commit into
loulanyue wants to merge 1 commit into
Conversation
|
This is clean. One line, one fix, no collateral damage. The issue is real — losing metadata during conversion can break downstream tools that rely on the index file. Preserving it from the source index is the correct behavior. This is the kind of PR that doesn't get much attention but saves someone debugging time later. — qingkong66 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
inference/fp8_cast_bf16.py, when writing the updatedmodel.safetensors.index.json, metadata was being overwritten with an empty dict{}instead of preservingmetadatafrom the source index (model_index.get("metadata", {})). This change preserves the original index metadata.