Skip to content

chore: updates coverage GH action to compare coverage against base branch - #28

Closed
0xItadaki wants to merge 21 commits into
devfrom
fix/upload-coverage-gh-action
Closed

chore: updates coverage GH action to compare coverage against base branch#28
0xItadaki wants to merge 21 commits into
devfrom
fix/upload-coverage-gh-action

Conversation

@0xItadaki

@0xItadaki 0xItadaki commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

1- When the PR is created, it runs the coverage in the base branch and caches result
2- With every push it calculates the coverage in the current PR and creates a comment with coverage information. This comment is updated every time there is a new push.
image

3- It compares the total coverage from the base branch and the new push. If the coverages decreases in the new push, a the comment is updated and the build fails

image

Note: yarn coverage only runs unit tests to avoid killing the RPC with fuzz tests
Note: It uses a sensitivity factor, otherwise the coverage fails even if nothing changes.

@0xItadaki
0xItadaki marked this pull request as ready for review August 26, 2025 12:54
@github-actions

github-actions Bot commented Aug 26, 2025

Copy link
Copy Markdown

LCOV of commit 17a74e0 during Coverage Check #149

Summary coverage rate:
  lines......: 67.0% (75 of 112 lines)
  functions..: 62.5% (15 of 24 functions)
  branches...: 100.0% (14 of 14 branches)

Files changed coverage rate: n/a

@0xItadaki 0xItadaki changed the title chore: testing GH action chore: updates coverage GH action to compare coverage against base branch Aug 26, 2025
@0xItadaki 0xItadaki self-assigned this Aug 26, 2025
@defi-wonderland defi-wonderland deleted a comment from linear Bot Aug 28, 2025
@0xItadaki 0xItadaki closed this Sep 23, 2025
@0xItadaki
0xItadaki deleted the fix/upload-coverage-gh-action branch September 23, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant