Skip to content

feat: implement IERC165 - #3

Merged
0xAustrian merged 26 commits into
devfrom
feat/implement-IERC165
Aug 20, 2025
Merged

feat: implement IERC165#3
0xAustrian merged 26 commits into
devfrom
feat/implement-IERC165

Conversation

@0xAustrian

@0xAustrian 0xAustrian commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes EFI-431, EFI-440

0xItadaki and others added 21 commits August 19, 2025 10:28
@0xItadaki
chore: removes boilerplate sample files
b0d05dd
@0xItadaki
fix: fixes micromatch security vulnerability
0df451e
@0xItadaki
docs: updates README header
af97185
@0xItadaki
chore: updates solc_version to 0.8.30
a414f97
@0xItadaki
chore: comments medusa and halmos CI tests
ed862f2
@0xItadaki
feat: adds IL2Resolver interface with variables
06dd078
@0xItadaki
feat: implements L2Resolver with constants and records mapping
4f9888e
@0xItadaki
feat: adds empty IENS and INameWrapper interfaces
b77398a
@0xItadaki
feat: implements L2Resolver constructor
78571ad
@0xItadaki
feat: makes state variables public
972f503
@0xItadaki
test: implements L2Resolver constructor unit tests
822121e
@0xItadaki
style: fixes _REVERSE_LOOKUP_NODE
1abdb94
@0xItadaki
chore: tidy up and clear boilerplate sample files (#1)
05ccc90 
Closes EFI-443

Created a
[PR](defi-wonderland/solidity-foundry-boilerplate#113)
for the security vulnerability in the boilerplate repo
@0xItadaki
Merge branch 'dev' into feat/L2Resolver-contract-constructor
21447d5
@0xItadaki
test: adds empty IntegrationL2Resolver to fix CI
909946a
@0xItadaki
refactor: makes REVERSE_LOOKUP_NODE public
e1fd7c5
@0xItadaki
style: removes unnecessary spaces
61d875a
@0xItadaki
chore: comments integration tests from CI
2323509
@0xItadaki
chore: fixes version to 0.8.30
1e0782c
@0xItadaki
feat: L2Resolver state variables and constructor w/unit tests (#2)
e1d50be 
# 🤖 Linear

Closes EFI-425
Closes EFI-434
@0xAustrian
feat: implement IERC165
62dab74
@0xAustrian 0xAustrian self-assigned this Aug 19, 2025
@linear

linear Bot commented Aug 19, 2025

Copy link
Copy Markdown
EFI-431 supportsInterface

  • function supportsInterface(bytes4 interfaceID) external pure returns (bool)
    • Implements ENSIP-165. Returns true for:
      • 0x01ffc9a7 (IERC165)
      • 0x9061b923 (ENSIP-10 ExtendedResolver interface)

@linear

linear Bot commented Aug 19, 2025

Copy link
Copy Markdown

EFI-440 supportsInterface

@0xAustrian
0xAustrian changed the base branch from dev to feat/L2Resolver-contract-constructor August 19, 2025 14:26
@0xItadaki
0xItadaki force-pushed the feat/L2Resolver-contract-constructor branch from 1e0782c to 9b05ec8 Compare August 19, 2025 14:33
Base automatically changed from feat/L2Resolver-contract-constructor to dev August 19, 2025 14:35
@0xAustrian
0xAustrian requested a review from 0xItadaki August 19, 2025 17:34
@0xAustrian
0xAustrian marked this pull request as ready for review August 19, 2025 17:34
0xItadaki
0xItadaki reviewed Aug 20, 2025
View reviewed changes
Comment thread test/unit/L2Resolver.t.sol
0xItadaki
0xItadaki reviewed Aug 20, 2025
View reviewed changes
Comment thread test/unit/L2Resolver.tree Outdated
0xItadaki
0xItadaki reviewed Aug 20, 2025
View reviewed changes
Comment thread src/interfaces/IExtendedResolver.sol
@@ -0,0 +1,12 @@
// SPDX-License-Identifier: MIT
pragma solidity 0.8.30;

@0xItadaki 0xItadaki Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay to leave out the interface comments when they are not ours, right?

@0xAustrian 0xAustrian Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added them only because the pre-commit fails without the natspec

@0xItadaki 0xItadaki Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I meant the @author, @title, etc type of comments. Do we need those or not needed since it is not our interface?

@0xAustrian 0xAustrian Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh got it, I think we can 100% skip them

0xItadaki
0xItadaki reviewed Aug 20, 2025
View reviewed changes
Comment thread package.json Outdated
0xItadaki
0xItadaki reviewed Aug 20, 2025
View reviewed changes
Comment thread remappings.txt
0xItadaki
0xItadaki previously approved these changes Aug 20, 2025
View reviewed changes

@0xItadaki 0xItadaki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🚀 Just a small nit in the .tree file and a bunch of questions 😃

@0xItadaki

0xItadaki commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

@0xAustrian I see the commit history is a bit messed up due to the updates we did yesterday. I guess that doesn't matter since they get squashed later, right?

@0xAustrian

0xAustrian commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@0xAustrian I see the commit history is a bit messed up due to the updates we did yesterday. I guess that doesn't matter since they get squashed later, right?

That's right, it will be hidden once we squash, and I'm not a big fan of force-push.

0xItadaki
0xItadaki previously approved these changes Aug 20, 2025
View reviewed changes
@0xAustrian
0xAustrian requested a review from 0xItadaki August 20, 2025 12:43
@0xAustrian
0xAustrian merged commit 58fd12b into dev Aug 20, 2025
4 checks passed
@0xAustrian
0xAustrian deleted the feat/implement-IERC165 branch August 20, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xItadaki 0xItadaki 0xItadaki approved these changes

Assignees

@0xAustrian 0xAustrian

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xAustrian @0xItadaki