chore: implements populate script - #33
Merged
Merged
Conversation
0xAustrian
reviewed
Aug 29, 2025
Contributor
There was a problem hiding this comment.
Can you grab this from out dir?
Comment on lines
+11
to
+15
| "@types/node": "^24.3.0", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^5.9.2", | ||
| "viem": "^2.36.0", | ||
| "vitest": "^3.2.4" |
Contributor
There was a problem hiding this comment.
Remember to use fixed versions.
|
|
||
| for (const item of batch) { | ||
| const subDomain = item.subDomain || item.shortName || item.name; // TODO: Review this | ||
| const domain = `${subDomain}${L2_SUFFIX}`; |
Contributor
There was a problem hiding this comment.
Should we lowerCase it first?
Collaborator
Author
There was a problem hiding this comment.
yeah, just in case
0xItadaki
marked this pull request as ready for review
August 29, 2025 12:00
0xAustrian
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes EFI-496
Example: