This repository was archived by the owner on Jul 10, 2026. It is now read-only.
test: benchmark comparison with expensive increment function - #108
Closed
0xShaito wants to merge 8 commits into
Closed
test: benchmark comparison with expensive increment function#1080xShaito wants to merge 8 commits into
0xShaito wants to merge 8 commits into
Conversation
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Co-authored-by: Claude <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
- Revert suffix naming to _latest/_new to match dev baseline uploads - Add assert(sum > 0) to prevent compiler from optimizing away the test loop Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
The Noir compiler was optimizing away the deterministic loop at compile time. By seeding the computation with msg_sender(), the compiler cannot evaluate the loop statically and must include it in the circuit. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
- Use aztec-benchmark action to run AND compare in one step (remove only_report) - Standardize on _base suffix (action's default) instead of custom naming - Add transition step to rename _latest files from dev to _base - Remove redundant manual benchmark run step Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Adds a 5000-iteration loop to the increment function to generate a significant gate count difference for benchmark comparison testing. Reverts workflow changes to use existing naming convention.
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing the benchmark artifact archive feature with a significantly more expensive increment function.
Changes
increment()functionPurpose
Validate that the benchmark comparison system correctly detects and reports significant performance regressions between branches.