This repository was archived by the owner on Jul 10, 2026. It is now read-only.
claude: fix comparison workflow ocwwh - #109
Merged
Merged
Conversation
The benchmark action was downloading baseline files and running the comparison, but never actually executing the benchmarks to generate the _new files needed for comparison. This caused comparisons to show no differences even when contract costs changed significantly. https://claude.ai/code/session_01TPZL9Jc2cibnFb11EV3b9N
…arison The comparison workflow was not working because: 1. The benchmark action never ran the benchmarks to generate comparison files 2. The suffix naming was inconsistent Changes: - Add benchmark execution step in PR workflow with _latest suffix - Change baseline files to use _baseline suffix for clarity - Update comparison to compare _baseline (base) vs _latest (current) - Simplify file handling by using consistent suffix naming Flow: - update-baseline.yml: generates *_baseline.benchmark.json for main/dev - pr-checks.yml: generates *_latest.benchmark.json for PR code - Comparison: _baseline vs _latest shows actual differences https://claude.ai/code/session_01TPZL9Jc2cibnFb11EV3b9N
The aztec-benchmark action defaults to running benchmarks itself when only_report is false. Since we already run benchmarks with yarn aztec-benchmark, we need to set only_report: true to make the action only generate the comparison report. Also explicitly pass reports_dir for clarity. https://claude.ai/code/session_01TPZL9Jc2cibnFb11EV3b9N
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.