This repository was archived by the owner on Jul 10, 2026. It is now read-only.
fix: benchmark comparison workflow suffix naming - #110
Closed
0xShaito wants to merge 1 commit into
Closed
Conversation
- Add explicit benchmark run step using yarn aztec-benchmark --suffix _latest - Add reports_dir parameter to external action - Change base_suffix from '_latest' to '_baseline' - Change current_suffix from '_new' to '_latest' - Add only_report: true to skip external action's benchmark execution - Update file cleanup and upload paths to use _baseline suffix This fixes the comparison showing Base: 0 because: 1. update-baseline.yml now creates files with _baseline suffix 2. PR workflow runs benchmarks with _latest suffix 3. External action only compares (only_report: true), doesn't run benchmarks 4. Naming is now consistent: baseline=_baseline, current=_latest Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Benchmark Comparison
Contract: counter
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Member
Author
|
Closing - reverting to original naming on test/benchmark instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base: 0by correcting suffix naming mismatchonly_report: trueflag to skip external action's unreliable benchmark executionRoot Cause
The comparison was failing because:
update-baseline.ymlcreated files with_latestsuffix_newsuffixnpx aztec-benchmarkwas unreliable_newfiles were generated → comparison returned empty/zero resultsChanges
.github/actions/benchmark/action.yml:Run benchmarksstep:yarn aztec-benchmark --suffix _latestreports_dir: ${{ inputs.bench-dir }}base_suffixfrom'_latest'to'_baseline'current_suffixfrom'_new'to'_latest'only_report: trueto use external action only for comparison, not execution_baselinesuffix.github/workflows/update-baseline.yml:_latestto_baseline_baselinesuffixNew Flow
update-baseline.yml (on push to dev/main):
yarn aztec-benchmark --suffix _baseline*_baseline.benchmark.jsonas artifactbenchmark/action.yml (on PR):
*_baseline.benchmark.json)yarn aztec-benchmark --suffix _latest(generates current)_baselinevs_latest(only_report: true)_baseline, uploads for PR branchTest plan
update-baseline.ymlworkflow runs and creates baseline with_baselinesuffix🤖 Generated with Claude Code