Skip to content
This repository was archived by the owner on Jul 10, 2026. It is now read-only.

chore: upgrade 5.0.0-rc.1 - #134

Merged
zkfrov merged 3 commits into
devfrom
chore/v5.0.0
Jul 6, 2026
Merged

chore: upgrade 5.0.0-rc.1#134
zkfrov merged 3 commits into
devfrom
chore/v5.0.0

Conversation

@0xLeopoldo

Copy link
Copy Markdown
Contributor

No description provided.

@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Upgrade Aztec dependencies to 5.0.0-nightly.20260529

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Upgrade Aztec dependencies from 4.3.0 to 5.0.0-nightly.20260529
• Update EmbeddedWallet configuration from pxeConfig to pxe parameter
• Update Noir contract dependency tag to match new version
• Bump project version to 5.0.0-nightly.20260529
Diagram
flowchart LR
  A["Aztec 4.3.0"] -- "upgrade" --> B["Aztec 5.0.0-nightly.20260529"]
  B --> C["Update package.json versions"]
  B --> D["Update Nargo.toml tag"]
  B --> E["Update EmbeddedWallet config"]

Loading

Grey Divider

File Changes

1. package.json Dependencies +10/-10

Upgrade all Aztec dependencies to 5.0.0-nightly

• Update project version from 4.3.0 to 5.0.0-nightly.20260529
• Upgrade all @aztec/* dependencies to 5.0.0-nightly.20260529
• Update aztecVersion config field to 5.0.0-nightly.20260529
• Update @aztec/foundation resolution to 5.0.0-nightly.20260529

package.json


2. src/ts/counter.test.ts ✨ Enhancement +1/-1

Update EmbeddedWallet config parameter name

• Change EmbeddedWallet configuration parameter from pxeConfig to pxe
• Maintains same configuration structure and values

src/ts/counter.test.ts


3. src/nr/counter_contract/Nargo.toml Dependencies +1/-1

Update Noir contract dependency version

• Update Aztec Noir dependency tag from v4.3.0 to v5.0.0-nightly.20260529

src/nr/counter_contract/Nargo.toml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Jun 1, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Benchmark toolchain pinned v4 ✓ Resolved 🐞 Bug ≡ Correctness
Description
The PR upgrades the repo’s @aztec/* dependencies to 5.0.0-nightly.20260529 while keeping the
benchmark toolchain and CI workflow references pinned to prerelease-022ee63, whose lockfile
dependencies are Aztec 4.2.0, and package.json additionally forces @aztec/foundation to v5 via
resolutions. As a result, benchmarks (locally and in CI) will run with a mixed/overridden Aztec
major-version graph—potentially loading Aztec 4.2.0 packages against 5.x foundation APIs—leading to
failures or unreliable results.
Code

package.json[R24-30]

+    "@aztec/accounts": "5.0.0-nightly.20260529",
+    "@aztec/aztec.js": "5.0.0-nightly.20260529",
+    "@aztec/entrypoints": "5.0.0-nightly.20260529",
+    "@aztec/noir-contracts.js": "5.0.0-nightly.20260529",
+    "@aztec/pxe": "5.0.0-nightly.20260529",
+    "@aztec/stdlib": "5.0.0-nightly.20260529",
+    "@aztec/wallets": "5.0.0-nightly.20260529",
Evidence
package.json shows the repository’s Aztec dependencies have been bumped to
5.0.0-nightly.20260529 and also enforces @aztec/foundation at that version via resolutions;
meanwhile yarn.lock indicates the pinned benchmark prerelease depends on Aztec 4.2.0 packages
such as @aztec/aztec.js and @aztec/wallets, and also demonstrates that requests for
@aztec/foundation@4.2.0 are being satisfied by the forced 5.0.0-nightly.20260529 resolution
(confirming the override is active). The GitHub workflows are pinned to the same
defi-wonderland/aztec-benchmark@prerelease-022ee63 ref, so CI benchmark runs will execute this
Aztec-4.2.0-based toolchain inside a repo now enforcing Aztec v5/foundation v5, creating a
cross-major mismatch.

package.json[23-32]
yarn.lock[1382-1390]
.github/workflows/pr-checks.yml[15-22]
.github/workflows/update-baseline.yml[16-22]
package.json[53-56]
yarn.lock[630-633]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The repo has been upgraded to Aztec `5.0.0-nightly.20260529`, but the benchmark toolchain (and CI workflow references) remain pinned to `prerelease-022ee63`, which pulls Aztec `4.2.0` packages; additionally, `package.json` forces `@aztec/foundation` to v5 via `resolutions`, causing Aztec 4.2.0 dependencies to resolve against a 5.x foundation. This produces a mixed/overridden dependency graph for benchmarks (local and CI) that is prone to runtime breaks or unreliable benchmark output.

## Issue Context
- `@defi-wonderland/aztec-benchmark` tarball is pinned to `4.2.0-prerelease.022ee63`.
- CI workflows call `defi-wonderland/aztec-benchmark` workflows at `@prerelease-022ee63`.
- `yarn.lock` shows that prerelease depends on Aztec `4.2.0` (e.g., `@aztec/aztec.js` / `@aztec/wallets`).
- `package.json` forces `@aztec/foundation` to `5.0.0-nightly.20260529` via `resolutions`, and `yarn.lock` indicates `@aztec/foundation@4.2.0` requests are being resolved to that 5.x version.
- Yarn resolutions apply transitively and can override nested packages’ expected versions.

## Fix Focus Areas
- package.json[23-33]
- package.json[53-56]
- .github/workflows/pr-checks.yml[15-22]
- .github/workflows/update-baseline.yml[16-22]

## Suggested fix
1. Upgrade `@defi-wonderland/aztec-benchmark` to a release/prerelease that is compatible with Aztec v5 (e.g., a corresponding `5.x` prerelease tarball).
2. Update GitHub workflow `uses:` references from `@prerelease-022ee63` to the matching v5-compatible benchmark workflow ref.
3. Keep `@aztec/foundation` `resolutions` aligned with the chosen single Aztec major-version set (preferably v5 once the benchmark toolchain is upgraded).
4. If a v5-compatible benchmark toolchain is not available yet, remove/relax the `@aztec/foundation` resolution so Aztec 4.2.0 dependencies can install the foundation version they declare, or pin **all** Aztec packages (including benchmark tooling) to one consistent compatible version set.
5. Re-run `yarn install` and commit the updated `yarn.lock` to ensure no forced cross-major overrides remain during benchmark execution.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

  • Author self-review: I have reviewed the code review findings, and addressed the relevant ones.

Qodo Logo

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Jun 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Re-trigger cubic

@github-actions

This comment has been minimized.

Comment thread package.json Outdated
@qodo-code-review

qodo-code-review Bot commented Jun 16, 2026

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit b8847ac

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Jun 16, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Re-trigger cubic

qodo-code-review[bot]
qodo-code-review Bot previously approved these changes Jun 16, 2026
@github-actions

This comment has been minimized.

@qodo-code-review

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit 7958fd7

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Re-trigger cubic

@github-actions

Copy link
Copy Markdown

Benchmark Comparison

CPU Cores RAM Arch
AMD EPYC 9V74 80-Core Processor 16 63 GiB x64

Contract: counter

🚦 Function Gates DA Gas L2 Gas Proving Time (ms)
Base PR Diff Base PR Diff Base PR Diff Base PR Diff
🟢 increment 416,973 291,231 -125,742 (-30.2%) 192 192 627,207 627,207 N/A N/A

@0xLeopoldo 0xLeopoldo changed the title chore: upgrade 5.0.0 chore: upgrade 5.0.0-rc.1 Jun 25, 2026
@zkfrov
zkfrov merged commit 7c9c901 into dev Jul 6, 2026
8 checks passed
@zkfrov
zkfrov deleted the chore/v5.0.0 branch July 6, 2026 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants