This repository was archived by the owner on Jul 10, 2026. It is now read-only.
test: e2e tests tokenized vault - authwits - #152
Merged
ilpepepig merged 70 commits intoJul 28, 2025
Merged
Conversation
…-wonderland/aztec-standards into feat/tokenized-vault-redeem-tests
…ized-vault-withdraw-tests
…-wonderland/aztec-standards into feat/tokenized-vault-redeem-tests
…vault-exact-tests
…ct-tests Signed-off-by: ilpepepig <167773062+ilpepepig@users.noreply.github.com>
…erland/aztec-standards into test/e2e-tests-tokenized-vault
ilpepepig
marked this pull request as ready for review
July 15, 2025 17:59
This comment was marked as outdated.
This comment was marked as outdated.
…dards into test/e2e-tests-tokenized-vault
…enized-vault-authwits
This comment was marked as outdated.
This comment was marked as outdated.
…c-standards into test/e2e-tests-tokenized-vault-authwits
…defi-wonderland/aztec-standards into test/e2e-tests-tokenized-vault-authwits
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| depositAction.with({ authWitnesses: [depositAuthWitness] }), | ||
| alice, | ||
| assetsAlice, | ||
| ); |
There was a problem hiding this comment.
Bug: Vault Authorization Overwrite Bug
The callVaultWithPrivateAuthWit function incorrectly overwrites existing authWitnesses on Aztec.js method calls. It replaces any pre-set authWitnesses (e.g., for deposit or issue operations) with only [transferAuthWitness], causing the original authorization to be lost and the vault operation to fail. A similar, inconsistent pattern exists in callVaultWithPublicAuthWit.
Locations (6)
| publicDepositAction.with({ authWitnesses: [publicDepositAuthWitness] }), | ||
| bob, | ||
| assetsBob, | ||
| ); |
There was a problem hiding this comment.
Bug: Incorrect Authwit Handling Causes Test Failures
A private authorization witness (authwit), generated by setPrivateAuthWit, is incorrectly passed to callVaultWithPublicAuthWit. This helper function is designed for public authwits and will ignore the private one, causing authorization failures in test cases involving private shares, such as deposit_public_to_private, issue_public_to_private, and deposit_public_to_private_exact.
Locations (3)
Contributor
Author
There was a problem hiding this comment.
Yes. Not the greatest variable name though.
This comment was marked as outdated.
This comment was marked as outdated.
Base automatically changed from
test/e2e-tests-tokenized-vault
to
feat/yield-bearing-token
July 25, 2025 17:17
…dards into test/e2e-tests-tokenized-vault-authwits
Benchmark ComparisonContract: nft
Contract: token
Contract: tokenized_vault
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
xorsal
approved these changes
Jul 28, 2025
| publicDepositAction.with({ authWitnesses: [publicDepositAuthWitness] }), | ||
| bob, | ||
| assetsBob, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes AZT-255
Description
Check parent linear issue for more context https://linear.app/defi-wonderland/issue/AZT-184/typescript-testing-suite
Note that the new tests are the ones inside
describe('Successful interactions with authwits.'.