This repository was archived by the owner on Jul 10, 2026. It is now read-only.
feat: replace vault deployer with generic cyclic deployer - #352
Closed
ilpepepig wants to merge 3 commits into
Closed
feat: replace vault deployer with generic cyclic deployer#352ilpepepig wants to merge 3 commits into
ilpepepig wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Benchmark Comparison
Contract: escrow
Contract: logic
Contract: nft
Contract: token
Contract: vault
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
wei3erHase
reviewed
Jun 15, 2026
Comment on lines
+436
to
+437
| { calldata_hash: Fr.ZERO }, | ||
| { calldata_hash: Fr.ZERO }, |
wei3erHase
reviewed
Jun 15, 2026
Comment on lines
85
to
-88
| #[external("public")] | ||
| fn set_shares_token_with_initial_deposit( | ||
| shares: AztecAddress, | ||
| initial_deposit: u128, | ||
| depositor: AztecAddress, | ||
| nonce: Field, | ||
| ) { | ||
| fn initial_deposit(initial_deposit: u128, depositor: AztecAddress, nonce: Field) { | ||
| assert(initial_deposit > 0, "initial_deposit must be greater than 0"); | ||
| let deployer = get_contract_instance_deployer_avm(self.address).unwrap(); | ||
| assert(self.msg_sender().eq(deployer), "caller is not deployer"); | ||
| self.storage.shares.initialize(shares); |
Member
There was a problem hiding this comment.
i thought set_shares_token_with_initial_deposit got deprecated already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes AZT-XXX
Description