Add confirmation dialogs to destructive SaveManager and ThemeManager actions#126
Open
corradedied wants to merge 4 commits into
Open
Add confirmation dialogs to destructive SaveManager and ThemeManager actions#126corradedied wants to merge 4 commits into
corradedied wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destructive and irreversible actions (overwrite, delete, reset) in
SaveManagerandThemeManagerpreviously executed immediately on click with no confirmation step, making accidental data loss easy.Window:AddDialogis now used to gate these actions behind a Cancel (Ghost) & action (Destructive) prompt:ThemeManager: Create theme (name collision only), Overwrite theme, Delete theme, Reset default theme
SaveManager: Create config (name collision only), Overwrite config, Delete config, Reset autoload config
For Create theme/config, the dialog only appears when the entered name already exists — a silent overwrite would otherwise occur. For all other destructive buttons, the dialog always appears.
Library.Windowis now stored on theLibraryobject at the end ofCreateWindowso addons can reachAddDialogviaself.Library.Windowwithout requiring a separate reference to be passed in.Screenshots
ThemeManagerSaveManager