Skip to content

Add confirmation dialogs to destructive SaveManager and ThemeManager actions#126

Open
corradedied wants to merge 4 commits into
deividcomsono:mainfrom
corradedied:confirmation-dialogs
Open

Add confirmation dialogs to destructive SaveManager and ThemeManager actions#126
corradedied wants to merge 4 commits into
deividcomsono:mainfrom
corradedied:confirmation-dialogs

Conversation

@corradedied

@corradedied corradedied commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Destructive and irreversible actions (overwrite, delete, reset) in SaveManager and ThemeManager previously executed immediately on click with no confirmation step, making accidental data loss easy.

Window:AddDialog is now used to gate these actions behind a Cancel (Ghost) & action (Destructive) prompt:

  • ThemeManager: Create theme (name collision only), Overwrite theme, Delete theme, Reset default theme

  • SaveManager: Create config (name collision only), Overwrite config, Delete config, Reset autoload config

For Create theme/config, the dialog only appears when the entered name already exists — a silent overwrite would otherwise occur. For all other destructive buttons, the dialog always appears.

Library.Window is now stored on the Library object at the end of CreateWindow so addons can reach AddDialog via self.Library.Window without requiring a separate reference to be passed in.

Screenshots

ThemeManager

image image image image

SaveManager

image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant