Notification queue cap (MaxNotifications)#130
Open
corradedied wants to merge 1 commit into
Open
Conversation
Added NotificationQueue and MaxNotifications. Updated notification handling to respect the maximum limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firing many notifications fast caused unbounded screen clutter with no way to remove old ones —
Library.Notificationsis an unordered dictionary, so "oldest" was unknowable.What changed
Library.NotificationQueue— ordered array parallel to the existing dict, so oldest is always[1]Library.MaxNotifications(default10) — on eachNotifyinsert, removes from the front of the queue until under cap.0= unlimited.Persistnotifications are exempt and will remain untouched.Data:Destroy()— removes the entry from the queue on natural expiry so dead references don't block future evictionsTemplates.Window+CreateWindow— wires the setting into the window config so it can be set at the call site:Unload path clears

NotificationQueuealongsideNotifications.