Skip to content

Rename plugin DLL prefix: ILMerged. -> Merged. #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bircck wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename plugin DLL prefix: ILMerged. -> Merged. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ To produce the deployable, merged and signed DLL, opt in with the `PackAndSignPl
dotnet build src/Dataverse/Plugins/Plugins.csproj -c Release -p:PackAndSignPlugin=true
```

**Caveat:** the Daxif deploy scripts expect `ILMerged.templatecompanyname.templateprojectname.Dataverse.Plugins.dll`, which is produced **only** when `-p:PackAndSignPlugin=true` is passed. A plain build does not produce it, so build with the flag before deploying the plugin locally. The pipeline already passes this flag, so CI output is unchanged.
**Caveat:** the Daxif deploy scripts expect `Merged.templatecompanyname.templateprojectname.Dataverse.Plugins.dll`, which is produced **only** when `-p:PackAndSignPlugin=true` is passed. A plain build does not produce it, so build with the flag before deploying the plugin locally. The pipeline already passes this flag, so CI output is unchanged.

# Quick start (dotnet new)

Expand Down
4 changes: 2 additions & 2 deletions src/Dataverse/Plugins/Plugins.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
<InputAssemblies Include="$(TargetDir)System.Threading.Tasks.Extensions.dll" />
<InputAssemblies Include="$(TargetDir)System.Text.Json.dll" />
</ItemGroup>
<Exec Command="$(PkgILRepack)\tools\ILRepack.exe /parallel /keyfile:..\..\..\templatecompanyname.snk /lib:$(TargetDir) /out:$(TargetDir)ILMerged.$(TargetFileName) @(InputAssemblies -> '%(Identity)', ' ')" />
<Exec Command="$(PkgILRepack)\tools\ILRepack.exe /parallel /keyfile:..\..\..\templatecompanyname.snk /lib:$(TargetDir) /out:$(TargetDir)Merged.$(TargetFileName) @(InputAssemblies -> '%(Identity)', ' ')" />
</Target>
<Target Name="SignDLL" AfterTargets="ILRepack" Condition="'$(PackAndSignPlugin)' == 'true'">
<Exec Command="signtool sign /p templatecertpassword /f ..\..\..\plugincert.pfx /tr http://timestamp.digicert.com /fd SHA256 /td SHA256 &quot;$(TargetDir)ILMerged.$(TargetFileName)&quot;" />
<Exec Command="signtool sign /p templatecertpassword /f ..\..\..\plugincert.pfx /tr http://timestamp.digicert.com /fd SHA256 /td SHA256 &quot;$(TargetDir)Merged.$(TargetFileName)&quot;" />
</Target>
<Import Project="..\SharedPluginLogic\SharedPluginLogic.projitems" Label="Shared" />
<Import Project="..\..\Shared\SharedContext\SharedContext.projitems" Label="Shared" />
Expand Down
2 changes: 1 addition & 1 deletion src/Tools/Daxif/_Config.fsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ module Path =
let webResourceProject = srcRoot ++ "Dataverse" ++ @"WebResources"
let webResourceFolder = webResourceProject ++ @"src" ++ (sprintf "%s_%s" PublisherInfo.prefix SolutionInfo.name)

let pluginDllName = "ILMerged.templatecompanyname.templateprojectname.Dataverse.Plugins"
let pluginDllName = "Merged.templatecompanyname.templateprojectname.Dataverse.Plugins"

/// Path information used by the SolutionPackager scripts
module SolutionPack =
Expand Down
Loading