Proposed refactor on Mesh.java by Arkka Dhiratara and Rucha Baphat#6
Open
arkka wants to merge 1 commit intodelftsre:masterfrom
Open
Proposed refactor on Mesh.java by Arkka Dhiratara and Rucha Baphat#6arkka wants to merge 1 commit intodelftsre:masterfrom
arkka wants to merge 1 commit intodelftsre:masterfrom
Conversation
- Provide jUnit test file: MeshTest.java - Refactor and rework extractVertexData() by introducing two new reusable methods createIndexBuffer() and createVertexBuffer() - Refactor prepareForAnim(Boolean) into two separated new methods, which are prepareForAnimSoftware() and prepareForAnimHardware() - Remove deprecated method setInterleaved(), because too long and not already used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is our effort to provide refactor to improve jMonkeyEngine for SRE course. As requested, here is squashed 1 commit file for our effort. For detailed commit message, please see https://github.com/arkka/jmonkeyengine/tree/refactor-mesh-extract-vertex-data
Provide jUnit test file: MeshTest.java
Refactor and rework extractVertexData() by introducing two new reusable methods createIndexBuffer() and createVertexBuffer()
Refactor prepareForAnim(Boolean) into two separated new methods, which are prepareForAnimSoftware() and prepareForAnimHardware()
Remove deprecated method setInterleaved(), because too long and not already used