Skip to content

assign_nested_cm_ids should use next_column_mapping_id #3247

Description

@nicklan

Today assign_nested_cm_ids does:

*max_id += 1;
nested_ids.insert(element_path.clone(), serde_json::Value::from(*max_id));

If max_id is already at the max int value, we will overflow. next_column_mapping_id exists exactly to solve this problem, we should use that instead of doing the +=1.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions