Skip to content

Clarify whether non-empty commit lists require latest_commit_file #3293

Description

@jtuglu1

Problem

LogSegment::try_new accepts LogSegmentFiles from internal callers. PR #3222 considered requiring latest_commit_file whenever ascending_commit_files is non-empty, but existing callers and legacy connector state may omit it.

Enforcing the invariant could reject previously accepted inputs even when the commit list is otherwise sufficient to construct the segment.

Goal

Determine whether every non-empty ascending_commit_files list can safely require latest_commit_file.

  • If yes, enforce the invariant and update all callers and tests.
  • If no, document when latest_commit_file may be absent and retain the optional behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions