feat!: add element-at expression - #3120
Open
DrakeLin wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3120 +/- ##
==========================================
+ Coverage 90.08% 90.19% +0.11%
==========================================
Files 248 250 +2
Lines 85653 86691 +1038
Branches 85653 86691 +1038
==========================================
+ Hits 77162 78195 +1033
+ Misses 5684 5676 -8
- Partials 2807 2820 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Benchmark results: ❌ Fail (a benchmark is ≥1.15x slower)Summary: 🚀 1 · ✅ 12 · ☑️ 1 · 🚧 0 · ❌ 1 Per-benchmark results (15 rows)
Legend: 🚀 ≥1.15x faster · ✅ faster or unchanged · ☑️ ≤1.03x slower · 🚧 1.03x-1.15x slower · ❌ ≥1.15x slower |
DrakeLin
force-pushed
the
stack/kernel-partition-timezone-scans
branch
from
August 13, 2026 23:51
502ee37 to
ea8e321
Compare
This was referenced Aug 13, 2026
DrakeLin
force-pushed
the
stack/kernel-partition-timezone-scans
branch
5 times, most recently
from
August 14, 2026 04:27
859810e to
f545df3
Compare
This was referenced Aug 14, 2026
DrakeLin
force-pushed
the
stack/kernel-partition-timezone-scans
branch
3 times, most recently
from
August 14, 2026 07:32
f70c857 to
206b81c
Compare
DrakeLin
force-pushed
the
stack/kernel-partition-timezone-scans
branch
from
August 14, 2026 16:20
206b81c to
a04cf06
Compare
DrakeLin
force-pushed
the
stack/kernel-partition-timezone-scans
branch
from
August 14, 2026 17:02
a04cf06 to
3400443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Add an
ElementAtexpression for row-wiseMap<String, String>lookup with dynamic keys and rightmost-duplicate semantics. Arrow and DataFusion share the behavior, predicate handling remains conservative, and unsupported FFI visitors receive an explicit unknown node.This PR affects the following public APIs
Add
ElementAtExpression,Expression::element_at, and theElementAtexpression variant.How was this change tested?
Unit, executor, serialization, predicate, and FFI tests cover dynamic and missing keys, nulls, duplicate keys, and expression traversal.