feat: add geometry arrow stats conversion - #3286
Draft
thinh2 wants to merge 1 commit into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3286 +/- ##
==========================================
- Coverage 90.28% 90.28% -0.01%
==========================================
Files 251 253 +2
Lines 88562 88705 +143
Branches 88562 88705 +143
==========================================
+ Hits 79960 80084 +124
- Misses 5718 5732 +14
- Partials 2884 2889 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thinh2
commented
Sep 9, 2026
| pub(crate) const GEOARROW_EXTENSION_METADATA_KEY: &str = "ARROW:extension:metadata"; | ||
| pub(crate) const GEOARROW_WKB_EXTENSION_NAME: &str = "geoarrow.wkb"; | ||
|
|
||
| pub(crate) fn geometry_geoarrow_metadata(geometry: &GeometryType) -> HashMap<String, String> { |
Collaborator
Author
There was a problem hiding this comment.
manually constructed the ArrowField metadata matching the the GeoArrow specification.
thinh2
commented
Sep 9, 2026
|
|
||
| use geoarrow_array::array::WktArray; | ||
| use geoarrow_array::cast::to_wkb; | ||
| use geoarrow_arrow_array_58::StringArray as GeoStringArray; |
Collaborator
Author
There was a problem hiding this comment.
pinned an arrow_array v58 for wkt_to_wkb_bytes conversion.
thinh2
commented
Sep 9, 2026
thinh2
left a comment
Collaborator
Author
There was a problem hiding this comment.
add comments for reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR adds the Arrow foundation for geometry support in the default engine.
Kernel
GeometryTypevalues now map to physical ArrowBinaryfields with GeoArrow WKBextension metadata, while geography remains unsupported in Arrow conversion for now.
It also teaches
parse_json_implto handle geometry stats encoded as WKT strings. The JSON pathdecodes geometry leaves through a string-first schema, converts valid WKT values to WKB bytes, and
keeps invalid geometry stats isolated to null cells in the parsed stats batch.
How was this change tested?