Fix group and channel invitations displayed as 1:1 invites#51
Merged
Conversation
Co-authored-by: adbenitez <24558636+adbenitez@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix group and channel invitations displayed as 1:1 invites
Fix group and channel invitations displayed as 1:1 invites
Feb 21, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where group and channel invitation links were incorrectly displaying the inviter's personal name instead of the group/channel name, making them indistinguishable from 1:1 personal invitations.
Changes:
- Reordered parameter lookup priority to check group (
g=) and broadcast/channel (b=) names before user name (n=) - Extended the "Join" button text condition to include broadcast parameter (
b=) alongside group parameter (g=) - Added comprehensive test coverage for the new parameter priority behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| index.html | Updated parameter priority to prefer group/channel names over user names, and extended join button logic to include broadcast parameter in both pre-i18n and i18next code paths |
| ui-test-_misc.js | Corrected existing test by removing stray g= parameter, and added new test cases for group-over-name, broadcast, and broadcast-over-name priority scenarios |
| ui-test-_localize.js | Added localization test for broadcast invitations to verify correct "Join" text is displayed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r10s
approved these changes
Feb 24, 2026
Member
|
did not check the tests, as i am not into that test framework. the other code changes lgtm - and are quite simple. it is really only displaying the other name |
adbenitez
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invite links for groups (
g=) and channels (b=) that also include the inviter's name (n=) were showing the user's name instead of the group/channel name, making them indistinguishable from personal invitations.Changes
b=(broadcast/channel), not justg=(group), in both thereactInput()pre-i18n path and the i18next callbacknamecontext (removed strayg=param), added cases for group-over-name priority, broadcast display, and broadcast-over-name priority; added broadcast localization testOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.