Fix TERM fallback in generated .zshrc - #36
Open
seven-mile wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#30 made the
TERMdefault conditional, but the line lives insidezshrc_template()'sunquoted heredoc, so
$TERMis expanded while~/.zshrcis generated instead of beingwritten literally. The install-time value gets baked in:
During
docker buildTERMis usually unset, so the guard is always true and the line isequivalent to the unconditional
export TERM=xtermthat #30 replaced — passing--env=TERM=xterm-256colorstill has no effect.Escaping the
$defers the check to shell startup, so~/.zshrcgets[ -z "$TERM" ] && export TERM=xtermregardless of the build environment.