Update zsh-in-docker.sh - #37
Open
gmli-eu wants to merge 1 commit into
Open
Conversation
Author
|
Found this issue while trying to update Claude Code .devcontainer dependencies during yesterday's GitHub outage. @deluan can you review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the Oh My Zsh installer URL from the legacy
robbyrussell/oh-my-zshrepository to the current officialinstall.ohmyz.shendpoint.The existing URL points to the old Oh My Zsh repository and can currently result in HTTP errors during the Docker build. Because the response is piped directly to
sh, these errors can surface as confusing shell syntax errors.The new URL is the official Oh My Zsh installation endpoint and is invoked with
curl -fsSLso HTTP failures cause the build to fail cleanly.Why?
The current installer URL:
https://raw.githubusercontent.com/robbyrussell/oh-my-zsh/master/tools/install.shis obsolete. Oh My Zsh has moved to the
ohmyzsh/ohmyzshrepository and provideshttps://install.ohmyz.shas an official installation endpoint.This keeps the existing one-line installation approach and does not change the user-facing behaviour of zsh-in-docker.
Changes
robbyrussell/oh-my-zshinstaller URL withhttps://install.ohmyz.shcurl -fsSLso HTTP errors are handled correctly