feat: keep the win chances block visible while it has nothing to count - #144
Merged
Conversation
The block used to disappear whenever the estimate was impossible, so the people who most need to know it exists — those without matches yet — never saw it. Now it always renders: WinChances reports why it cannot estimate (too few players, or fewer than two with a rating) instead of returning nil, and the view spells that reason out next to a short list of what will fill the block once the ratings are there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block used to disappear whenever the estimate was impossible, so the people who most need to know it exists — those without matches yet — never saw it. Now it always renders: WinChances reports why it cannot estimate (too few players, or fewer than two with a rating) instead of returning nil, and the view spells that reason out next to a short list of what will fill the block once the ratings are there.