fix: name both sides of a match in the tennis life feed - #145
Merged
Conversation
The card read the opponent off Match#opponent_id alone, which doubles rows never carry, so a four-player match showed up as "Denis vs Anonymous player". It now builds each side out of the team ids in stats, keeps the row's own player first and names the guests who have no account, so the same match reads "Denis + Максим vs Irina + Саня Б (guest)". The outcome line goes with it: the score is written from the named side's perspective, so "Result: Loss" only repeated what "6-7(5) 3-4" already said. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The card read the opponent off Match#opponent_id alone, which doubles rows never carry, so a four-player match showed up as "Denis vs Anonymous player". It now builds each side out of the team ids in stats, keeps the row's own player first and names the guests who have no account, so the same match reads "Denis + Максим vs Irina + Саня Б (guest)".
The outcome line goes with it: the score is written from the named side's
perspective, so "Result: Loss" only repeated what "6-7(5) 3-4" already said.