feat: pick a court by country and city in the game form - #152
Merged
Conversation
The court select listed all 349 approved courts in id order, so a player had to scroll through Melbourne and Doha to reach the club next door. Two selects above it narrow the list down the way the coach search does, the remaining options are grouped by city, and the map keeps only the courts still listed. The starting city is the one of the game's court, or the player's own city — matched on a normalized name, so "Ekaterinburg" finds courts in "Yekaterinburg". The filters carry no name attribute and never reach the server. Countries for cities the geocoder returned as a district or under a name the City table does not carry (Greater London, Chaoyang District, New York and ten more) now come from CITY_COUNTRY_OVERRIDES, which also fixes the country filter on the games, courts and coaches pages. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The court select listed all 349 approved courts in id order, so a player had to scroll through Melbourne and Doha to reach the club next door. Two selects above it narrow the list down the way the coach search does, the remaining options are grouped by city, and the map keeps only the courts still listed.
The starting city is the one of the game's court, or the player's own city — matched on a normalized name, so "Ekaterinburg" finds courts in "Yekaterinburg". The filters carry no name attribute and never reach the server.
Countries for cities the geocoder returned as a district or under a name the City table does not carry (Greater London, Chaoyang District, New York and ten more) now come from CITY_COUNTRY_OVERRIDES, which also fixes the country filter on the games, courts and coaches pages.