feat: tell namesake courts apart by street in the game form - #154
Merged
Conversation
Yekaterinburg has two "Территория сквоша" — one in Greenwich, one on Kosmonavtov — and the court select showed the same line twice, so a player picking one of them was guessing. The address only lived in the geocoding cache, expired daily and came from Nominatim as a display_name that starts with the venue itself, so it could not be used for a label. The resolver now returns the street line it already assembles (route plus house number from Google, road plus house_number from Nominatim) and the address job stores it on the court. The picker appends it in parentheses only to names that repeat within their city group — the rest of the list stays as it was. Existing courts keep an empty street until geocoding:backfill_court_streets re-runs the address job for them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…in-picker # Conflicts: # db/schema.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yekaterinburg has two "Территория сквоша" — one in Greenwich, one on Kosmonavtov — and the court select showed the same line twice, so a player picking one of them was guessing. The address only lived in the geocoding cache, expired daily and came from Nominatim as a display_name that starts with the venue itself, so it could not be used for a label.
The resolver now returns the street line it already assembles (route plus house number from Google, road plus house_number from Nominatim) and the address job stores it on the court. The picker appends it in parentheses only to names that repeat within their city group — the rest of the list stays as it was.
Existing courts keep an empty street until geocoding:backfill_court_streets re-runs the address job for them.